Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove unused fields verifyingContract & salt from EIP712 domain separator #75

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Sep 10, 2024

This is a breaking change as it changes the expected fields in the EIP712 data that is signed.

  • Set verifyingContract field to empty string to exclude it
  • Salt is also set to empty as it is unused
  • Remove the types for verifyingContract and Salt as it is unused now the fields are omitted.

To be backported to kava/release/v0.27.x release branch no longer to be included in a standalone upgrade

Salt: "0",
Name: "Kava Cosmos",
Version: "1.0.0",
ChainId: math.NewHexOrDecimal256(int64(chainID)),

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@drklee3 drklee3 changed the title fix: Remove VerifyingContract field from EIP712 domain separator fix: Remove unused field verifyingContract & salt from EIP712 domain separator Sep 10, 2024
@drklee3 drklee3 changed the title fix: Remove unused field verifyingContract & salt from EIP712 domain separator fix: Remove unused fields verifyingContract & salt from EIP712 domain separator Sep 10, 2024
@drklee3 drklee3 changed the title fix: Remove unused fields verifyingContract & salt from EIP712 domain separator fix!: Remove unused fields verifyingContract & salt from EIP712 domain separator Sep 10, 2024
somehow deleted this on accident
{ "name": "chainId", "type": "uint256" },
{ "name": "verifyingContract", "type": "string" },
{ "name": "salt", "type": "string" }
{ "name": "chainId", "type": "uint256" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected EIP712Domain has the two fields removed now

@drklee3 drklee3 merged commit 65384e0 into main Sep 19, 2024
26 of 27 checks passed
@drklee3 drklee3 deleted the dl-eip712-domainsep-fix branch September 19, 2024 18:42
pirtleshell pushed a commit that referenced this pull request Oct 25, 2024
…n separator (#75)

verifyingContract field is validated by MetaMask to be an address, but was expected to be a string. This field is unused so it is removed.
pirtleshell pushed a commit that referenced this pull request Oct 25, 2024
…n separator (#75)

verifyingContract field is validated by MetaMask to be an address, but was expected to be a string. This field is unused so it is removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants