Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #12

Merged
merged 1 commit into from
Dec 9, 2020
Merged

fix #12

merged 1 commit into from
Dec 9, 2020

Conversation

thorewi
Copy link

@thorewi thorewi commented Nov 16, 2020

No description provided.

@martenb
Copy link

martenb commented Nov 21, 2020 •
edited
Loading

AFAIK fixes Kdyby/Translation#178

@jkavalik
Copy link

Maybe this could add a conflict clause to composer.json for older latte?

@lulco
Copy link

lulco commented Dec 9, 2020

@enumag can you check this PR?

@enumag enumag merged commit 52dcae6 into Kdyby:2.0 Dec 9, 2020
@enumag
Copy link
Member

enumag commented Dec 9, 2020

Please send a PR with adding PHP 7.3 and 7.4 to travis. #10 did it for master but we need it for 2.0 branch as well in order to release 2.0.1. Thanks.

@jkavalik jkavalik mentioned this pull request Dec 15, 2020
Merged
@jkavalik
Copy link

jkavalik commented Dec 16, 2020 •
edited
Loading

so after this fix I am now getting
Declaration of Kdyby\StrictObjects\Scream::__get(string $name) should be compatible with & Latte\Macros\MacroSet::__get(string $name)
and I am not sure if that can be fixed simply by adding & or if it means problems.

-- EDIT --
Solved by correcting the tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enumag enumag enumag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thorewi @martenb @jkavalik @lulco @enumag