data #228 - Credit cards can be created with security parameters.

KeepItSimpleStupid · May 14, 2013 · f5db2e6 · f5db2e6
1 parent d6f2875
commit f5db2e6
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/src/main/java/com/braintreegateway/CreditCardRequest.java b/src/main/java/com/braintreegateway/CreditCardRequest.java
@@ -9,6 +9,7 @@ public class CreditCardRequest extends Request {
     private String cardholderName;
     private String customerId;
     private String cvv;
+    private String deviceSessionId;
     private String expirationDate;
     private String expirationMonth;
     private String expirationYear;
@@ -51,6 +52,11 @@ public CreditCardRequest cvv(String cvv) {
         return this;
     }
 
+    public CreditCardRequest deviceSessionId(String deviceSessionId) {
+        this.deviceSessionId = deviceSessionId;
+        return this;
+    }
+
     public CustomerRequest done() {
         return parent;
     }
@@ -138,6 +144,7 @@ protected RequestBuilder buildRequest(String root) {
             addElement("cardholderName", cardholderName).
             addElement("cvv", cvv).
             addElement("number", number).
+            addElement("deviceSessionId", deviceSessionId).
             addElement("expirationDate", expirationDate).
             addElement("expirationMonth", expirationMonth).
             addElement("expirationYear", expirationYear).

diff --git a/src/test/java/com/braintreegateway/integrationtest/CreditCardIT.java b/src/test/java/com/braintreegateway/integrationtest/CreditCardIT.java
@@ -110,6 +110,20 @@ public void createWithXmlCharacters() {
         assertEquals("Special Chars <>&\"'", card.getCardholderName());
     }
 
+    @Test
+    public void createWithSecurityParams() {
+        Customer customer = gateway.customer().create(new CustomerRequest()).getTarget();
+        CreditCardRequest request = new CreditCardRequest().
+            customerId(customer.getId()).
+            cardholderName("Special Chars").
+            number("5105105105105100").
+            expirationDate("05/12").
+            deviceSessionId("abc123");
+        Result<CreditCard> result = gateway.creditCard().create(request);
+
+        assertTrue(result.isSuccess());
+    }
+
     @Test
     public void createWithAddress() {
         Customer customer = gateway.customer().create(new CustomerRequest()).getTarget();

diff --git a/src/test/java/com/braintreegateway/integrationtest/CreditCardRequestIT.java b/src/test/java/com/braintreegateway/integrationtest/CreditCardRequestIT.java
@@ -1,6 +1,7 @@
 package com.braintreegateway.integrationtest;
 
 import com.braintreegateway.CreditCardRequest;
+import com.braintreegateway.testhelpers.TestHelper;
 import org.junit.Test;
 
 import static org.junit.Assert.assertEquals;
@@ -12,6 +13,13 @@ public void toXmlEscapesXmlChars() {
             cardholderName("Special Xml Chars <>&\"'");
         assertEquals("<creditCard><cardholderName>Special Xml Chars &lt;&gt;&amp;&quot;&apos;</cardholderName></creditCard>", request.toXML());
     }
+    @Test
+    public void toXmlIncludesSecurityParams() {
+        CreditCardRequest request = new CreditCardRequest().
+            deviceSessionId("dsid_abc123");
+
+        TestHelper.assertIncludes("dsid_abc123", request.toXML());
+    }
 
     @Test
     public void toQueryString() {