Skip to content

Commit

Permalink
formatted readme, added screenshots, guideline (#313)
Browse files Browse the repository at this point in the history
  • Loading branch information
lazyturd authored Aug 27, 2022
1 parent b5f4a87 commit 0f03354
Show file tree
Hide file tree
Showing 7 changed files with 162 additions and 25 deletions.
187 changes: 162 additions & 25 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,56 +12,193 @@

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/KendallDoesCoding/mogul-christmas)



# Introduction

This is a project where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it unique is that it has lyrics of the songs and a bunch of other features like a photo gallery.

On the 18th of December 2021, I was bored, so I created this basic HTML Project. I felt like continuing with this fun project, so I enlisted the help of a few contributors.

## Check it out here
The project website is hosted [here](https://kendalldoescoding.gq/mogulchristmas)!

Backup URL: [Backup Domain](https://mogulchristmas.netlify.app)

Make sure you check it out.


# Build Status

You can view the versions & previews [here](https://mogulchristmas.kendalldoescoding.gq/versionsandpreviews)

**Please Note: This only has 25 releases, at the time of writing this (16th April 2022, 12:11pm IST) there are 59 more releases not added to this list.**

- For updates on the website, I've written it as a Version, and for updates on Github we've written it as a Release, for Releases, we've provided a complete changelog.

- If you would prefer dark mode on this site, you can toggle dark mode on or off by using the button in the top right corner of the site.

Please note that since version 8.0, we have updated how the website looks so that there is no embed/iframe. While that does slow down the performance(how fast the song plays and the user does not know if the song is loading or not), the song should play in 1-5 seconds. In case of any issue, please create a bug report issue using the template in the issue panel in this repo.
However, since the release of 10.5.0, the songs have started playing a little faster than they used to, only taking only 1-4 seconds.


# Deploy Status

Below, you can see the progress of the GitHub deployment to the site. In case a change is made to this repo, it takes around 2-5 minutes to display on the site, depending on if there are other deploy's going on within Pull Requests or within repos that have sites, because using Netlify, I can only deploy one thing at a time.

[![Netlify Status](https://api.netlify.com/api/v1/badges/c9a61158-0ccb-489e-ba45-85eafcf4bc3b/deploy-status)](https://app.netlify.com/sites/mogulchristmas/deploys)


# Images From Website
## Landing Page
<img src="images\screenshots\mogul-christmas-1.jpg" alt="MarineGEO circle logo"/>

## Landing Page (Dark Mode)
<img src="images\screenshots\mogul-christmas-dark-mode.jpg" alt="MarineGEO circle logo"/>

## Photo Gallery
<img src="images\screenshots\photo-gallery.jpg" alt="MarineGEO circle logo"/>

## Songs With Lyrics
<img src="images\screenshots\video-with-lyrics.jpg" alt="MarineGEO circle logo"/>

## Recommended Songs
<img src="images\screenshots\song-recommendations.jpg" alt="MarineGEO circle logo"/>

## Important

**Please ensure that the last YouTube video you watched wasn't on mute, otherwise the songs will not play, and the autoplay for the lyrics' directory will automatically be set on mute too.**
**Please ensure that the last YouTube video you watched wasn't on mute, otherwise the songs will not play, and the autoplay for the lyric's directory will automatically be set on mute too.**

**There is currently no way to control the volume of the songs. Although it should be added soon, you can lower the volume on your device. If that is still too loud, please download the [Volume Booster extension](https://chrome.google.com/webstore/detail/volume-master/jghecgabfgfdldnmbfkhmffcabddioke) (even though it is meant to boost volume, it can also be used as a reducer; available on Brave, Edge, Chrome, I am not sure about Firefox, etc) and lower the volume there. On the project site, we are developing an in-built volume slider. [Please leave a message](https://github.com/KendallDoesCoding/mogul-christmas/issues/105) if you are willing to assist. Thanks.**

**Also, I recommend that you use [Adblocker Plus](https://mogulchristmas.kendalldoescoding.gq/adblockerplus) or another adblocker to block ads on YouTube and the project website if the sites are not whitelisted in the adblocker because there is a chance that an ad will play before you click a song. After all, this project is powered by a YouTube embed. However, I may soon change it to run through Youtube Music or another music software where the ads are fewer or none at all. There is one adblocker that allows you to whitelist ads on a specific YouTuber; if you use that adblocker and whitelist, say, "Ludwig," you may get ads, so please un-whitelist him while running the songs on the project website. But, because there are not many ads, you should be fine most of the time. My adblocker tells me that for every song I tap on the website, including "All Of The Above," it is blocking two ads; however, when I tried another login without the adblocker, I did not get any ads, so the ads will only appear occasionally; I am just providing fair warning.**



If you would like dark mode on this site, you can toggle dark mode on or off by using the button in the top right corner of the site.

Please note that since version 8.0, we have updated how the website looks so that there is no embed/iframe, but that does slow down the performance how fast the song plays/the user does not know if the song is loading or not, but just wait 1-5 seconds and the song should play, in case of any issue, please create a bug report issue using the template in the issue panel in this repo. Since the release of 10.5.0, I believe, the songs have started playing a little faster than they used to, now taking only 1-4 seconds.
# Contributing Guidelines & Related Contributing Stuff

## Check it out here
**[Contributing Guidelines](./.github/CONTRIBUTING.md)**

The project website is hosted [here](https://kendalldoescoding.gq/mogulchristmas)!
Your contributions are always welcome!

Backup URL: [Backup Domain](https://mogulchristmas.netlify.app)
Please go through the active issues, before you plan to contribute.

Make sure you check it out.
# How to contribute

## Contributing Guidelines & Related Contributing Stuff
There are different ways to use git and GitHub.
In this tutorial we will try to keep stuff simple and therefore use the command line.

[Contributing Guidelines](./.github/CONTRIBUTING.md)
## Find an issue

[Issues which new contributors can take up.](https://github.com/KendallDoesCoding/mogul-christmas/contribute)
While viewing the repository you can use the tap "Issues" to view and filter [open issues](https://github.com/KendallDoesCoding/mogul-christmas/issues).
There are some tags like "good first issue" or "beginner" that might be of special interest to you.

## Credits

**Project credits are located [here](https://mogulchristmas.kendalldoescoding.gq/credits).**
## Fork the repository

_Credits include the following_:
### Why should you fork the repository?
A fork of a repository is a copy that still remembers where it came from.
Advantages of this are:
- You can open your **own branches** separate from the forked (upstream) repository.
- You can easily keep your repository **up to date** by simply pulling changes from upstream.
- Once you have finished making the changes you want to make, **suggesting this changes** for the original is very easy.

- Mogul Christmas Team
- Project Contributors
- Singers whose songs are in the You May Like directory.
Using forks and pull request makes developing with many contributors less complicated for everybody involved!

## Versions & Previews
### How to fork the repository

- You can view the versions & previews [here](https://mogulchristmas.kendalldoescoding.gq/versionsandpreviews)
As long as you are visiting the repository there is a button called "fork" on the top right of the page.
By clicking it and confirming you can fork the repository.

**Please Note: This only has 25 releases, at the time of writing this (16th April 2022, 12:11pm IST) there are 59 more releases not added to this list.**
***For the next steps you need to have git installed on your device.
If you haven't already done that, [this page](https://git-scm.com/downloads) might help.***

- For updates on the website, I've written it as a Version, and for updates on Github we've written it as a Release, for Releases, we've provided a complete changelog.
## Clone your version of the repository

## Deploy Status
### Why do we clone the repository?

Below, you can see the progress of the GitHub deployment to the site. In case a change is made to this repo, it takes around 2-5 minutes to display on the site, depending on if there are other deploy's going on within Pull Requests or within repos that have sites, because using Netlify, I can only deploy one thing at a time.
After forking a repository it still is not local on your device.
For bringing the repository on your device you need to clone it.

[![Netlify Status](https://api.netlify.com/api/v1/badges/c9a61158-0ccb-489e-ba45-85eafcf4bc3b/deploy-status)](https://app.netlify.com/sites/mogulchristmas/deploys)
### How to clone

Go to your version of the repository, click on the "Code" button and choose one of three ways: HTTPS, ssh or GitHub Cli.
Copy the line beneath the method.

Open a terminal and navigate to where you want to place the repository.
Enter
`git clone <copied url>`

## Create a branch

**Working on branches helps keeping different versions of your code and different uncompleted features from becoming a big mess.
You ***never*** work directly on the main branch (sometimes also called master).**

Change to the repository directory on your computer (if you are not already there):

`cd food-up`

Now create a branch using the git checkout command:

`git checkout -b your-new-branch-name`

For example:

git checkout -b do-something

## Make necessary changes

Do whatever you planned to do.

## Commit changes

### Adding files

For adding specific files:
`git add <filename>`

**Be sure only files you wish to add have been changed. Use `git status` to check.**

### Committing added files

Use
`git commit -m "<commit message>"`
Your commit message should describe the changes you have made.

## Push changes to GitHub

To make your local changes visible for remote (so you can see and interact with them on GitHub) you need to push them.

Push your changes using the command git push:

`git push origin <add-your-branch-name>`

## Create a pull request

In your repository on GitHub, you'll see a "Compare & pull request" button. Click on that button.

You will have the option to give some additional information to the changes your pull request is going to cause by entering text.
After you have done that, create the pull request by clicking on "Create pull request".

## Wait for review

Your reviewer might merge the request or ask for you to make some changes.

***If there are some improvements you need to do, don't worry:***
Everything you push on your branch will now be added to the pull request. (That is one of the reasons we need different branches for different issues!).
You can use the comments to ask for clarification if needed. As soon as the reviewer is happy, your changes will be merged.
(Remember: your reviewer is a person who tries to work for the good of all. Don't ever be harsh with them, especially if they wish for multiple changes.)


### Happy Coding!

[Issues which new contributors can take up.](https://github.com/KendallDoesCoding/mogul-christmas/contribute)

# Credits

**Project credits are located [here](https://mogulchristmas.kendalldoescoding.gq/credits).**

_Credits include the following_:

- Mogul Christmas Team
- Project Contributors
- Singers whose songs are in the You May Like directory.
Binary file added images/screenshots/ludwig-socials.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/screenshots/mogul-christmas-1.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/screenshots/mogul-christmas-dark-mode.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/screenshots/photo-gallery.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/screenshots/song-recommendations.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/screenshots/video-with-lyrics.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 0f03354

Please sign in to comment.