Add Particle Effect on Enemy Destruction #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had left a comment on reddit suggesting adding a particle effect when an enemy is destroyed to give the demo a little more impact. This is my (fairly rushed) attempt at implementing something for that. This PR adds an explosion.tscn with a simple particle effect I made and a timer to remove the particle spawner once it's no longer needed. I also updated the enemy script to add the explosion to the scene at the enemy's position when it's destroyed.
The particle effect I made for this is really simplistic, and I'm not sure it's at the same quality as the starter kit as a whole, so I would understand not merging this as-is. I wanted to make the PR for it, though, to have a place for discussion as well as see if there's any ideas to improve it. Right now the particles themselves are very simplistic, just being colored cubes. The mesh and material could be swapped out for something better, and the choice of colors could maybe be improved (I'm colorblind, so I wasn't sure about the best choice of colors). Feel free to mess with this in the editor, but do note that because of godotengine/godot#17903 you'll need to make sure you re-enable
emitting
before saving the scene.