Fix PAM properties not being unregistered correctly

Kerbalight · Feb 25, 2024 · 9d7a734 · 9d7a734
1 parent fd89923
commit 9d7a734
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/plugin_template/assets/bundles/commnext_ui.bundle b/plugin_template/assets/bundles/commnext_ui.bundle
diff --git a/src/CommNext/Modules/Modulator/Module_NextModulator.cs b/src/CommNext/Modules/Modulator/Module_NextModulator.cs
@@ -41,13 +41,23 @@ public override void OnInitialize()
     /// </summary>
     private void OnOmniBandChangedValue(bool isOmniBand)
     {
-        dataModulator!.SetInteractable(dataModulator!.Band, !isOmniBand);
-        dataModulator!.SetInteractable(dataModulator!.SecondaryBand, !isOmniBand);
         part.partOwner.SimObjectComponent.SimulationObject.Telemetry.RefreshCommNetNode();
     }
 
     private void OnBandChangedValue(string band)
     {
         part.partOwner.SimObjectComponent.SimulationObject.Telemetry.RefreshCommNetNode();
     }
+
+    public override void OnShutdown()
+    {
+        base.OnShutdown();
+        var modulator = dataModulator;
+        if (modulator != null)
+        {
+            modulator.OmniBand.OnChangedValue -= OnOmniBandChangedValue;
+            modulator.Band.OnChangedValue -= OnBandChangedValue;
+            modulator.SecondaryBand.OnChangedValue -= OnBandChangedValue;
+        }
+    }
 }
diff --git a/src/CommNext/Modules/Relay/Module_NextRelay.cs b/src/CommNext/Modules/Relay/Module_NextRelay.cs
@@ -36,4 +36,11 @@ private void OnEnableRelayChange(bool isEnabled)
     {
         part.partOwner.SimObjectComponent.SimulationObject.Telemetry.RefreshCommNetNode();
     }
+
+    public override void OnShutdown()
+    {
+        base.OnShutdown();
+        var relay = dataRelay;
+        if (relay != null) relay.EnableRelay.OnChangedValue -= OnEnableRelayChange;
+    }
 }