Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bootstrap4 custom breakpoints #9

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jhotadhari
Copy link

Hi,
its just a proposal.
I don't need that feature actually. no rush.

Added a function to extract all bs4 breakpoints from from :root style properties.

Why? Usecase

For example a project, that overwrites the $grid-breakpoints variable:

$grid-breakpoints: (
  xs: 0,
  xssm: 411px,
  sm: 592px,
  md: 782px,
  lg: 992px,
  xl: 1200px
);

Results to this :root style properties:
image

The custom breakpoint icon will use the default text color:
image

Disadvantages

Couldn't find a direct way to extract the breakpoint properties. Therefor its done with a loop, which takes time.
For me, it's around 5-8ms per pageload.

May be this feature might be better to opt out on default.

@necodeus
Copy link

necodeus commented Apr 17, 2021

I love the idea. You could also add a way to customize breakpoints via extension settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants