Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Addition of popular image retrieval benchmark datasets #724

Merged
merged 19 commits into from
Dec 11, 2024

Conversation

ir2718
Copy link
Contributor

@ir2718 ir2718 commented Oct 26, 2024

Hi,

this is a PR for issue #722. I've implemented four benchmark datasets: CUB-200, Cars196, INaturalist2018, and StanfordOnlineProducts. When using any of these datasets they will be downloaded directly and saved to the root directory, similar to the PyTorch dataset handling. Each of the implemented datasets inherits torch.utils.data.Dataset and can be used with dataloaders seamlessly. I've also added docs for each of the datasets implement, and a short overview of what users need to implemented if they want to add their own custom dataset. Tests for each of the datasets are also added. I've deliberately left out the __init__.py in tests/datasets, as each of the files has to be downloaded, and these can be pretty big (up to 130Gb).

@KevinMusgrave when you have time, please take a look and tell me if something requires changing.

@KevinMusgrave KevinMusgrave changed the base branch from master to dev October 28, 2024 12:25
@ir2718
Copy link
Contributor Author

ir2718 commented Nov 30, 2024

Are there any plans on merging this or would you like me to make some changes?

@KevinMusgrave
Copy link
Owner

Looks good I think, but it would be nice to get more "official" links for SOP and Cars, but especially for SOP because I don't like having people download an anonymous-looking google drive link 😅

@ir2718
Copy link
Contributor Author

ir2718 commented Dec 3, 2024

Regarding the Cars dataset, unfortunately the original website is down. Even torchvision mentions this in their docs.

For SOP the used link is actually the official link. You can see the same link here in the readme of their repository.

@KevinMusgrave KevinMusgrave merged commit c82c626 into KevinMusgrave:dev Dec 11, 2024
19 checks passed
@KevinMusgrave
Copy link
Owner

Thanks @ir2718!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants