Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release23dev #92

Merged
merged 10 commits into from
Nov 16, 2023
Merged

Release23dev #92

merged 10 commits into from
Nov 16, 2023

Conversation

bhillkeyfactor
Copy link
Contributor

No description provided.

@bhillkeyfactor
Copy link
Contributor Author

@fiddlermikey @rcpokorny @RexWheeler - Can you guys review this? I had to go through a lot to get this to merge properly and wanted to make sure I did not miss anything....

Copy link
Collaborator

@rcpokorny rcpokorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the SQL code was added along with the updated ReadMe text.
One suggestion I would make (as this was done for WinCert) would be to make the Private Key Handling 'Optional' as opposed to 'Required'. I'm not sure if that would make sense or not.

Copy link
Contributor

@fiddlermikey fiddlermikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme: Store Types and Stores detail sections added for new SQL Server types.

@bhillkeyfactor
Copy link
Contributor Author

@fiddlermikey - can you merge this when you get a minute? My merging is blocked.

@fiddlermikey fiddlermikey merged commit 7e15ec8 into release-2.3 Nov 16, 2023
12 checks passed
fiddlermikey added a commit that referenced this pull request Nov 16, 2023
* SQL Merge

Co-authored-by: Brian Hill <[email protected]>
@RexWheeler
Copy link
Contributor

@fiddlermikey Looks like we have still lost the contents of PR88, those changes need to be included here (or at least end up in the release)

@rcpokorny
Copy link
Collaborator

rcpokorny commented Nov 16, 2023 via email

@fiddlermikey fiddlermikey deleted the release23dev branch July 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants