Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor python progress callback #266

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Refactor python progress callback #266

merged 2 commits into from
Dec 28, 2023

Conversation

hendrikmuhs
Copy link
Contributor

move the progress callback to a more obvious place and fix cython warning

narekgharibyan
narekgharibyan reviewed Dec 28, 2023
View reviewed changes
Copy link
Member

@narekgharibyan narekgharibyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hendrikmuhs hendrikmuhs merged commit d4101a6 into master Dec 28, 2023
49 checks passed
@hendrikmuhs hendrikmuhs deleted the refactor-progress-callback branch December 28, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narekgharibyan narekgharibyan narekgharibyan approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hendrikmuhs @narekgharibyan