Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Speaker Peripheral #2

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Added Speaker Peripheral #2

merged 2 commits into from
Mar 26, 2024

Conversation

aprowe
Copy link
Contributor

@aprowe aprowe commented Mar 24, 2024

This seems to work? but not exactly sure how to write data correctly it plays the tone but then repeats the last bit of it.
New to I2S so pretty clueless 🤷

@Kezii
Copy link
Owner

Kezii commented Mar 24, 2024

if you can fix the build it can be merged

also update the readme, feel free to add "not tested" in it if you think like this is not complete

@Kezii Kezii merged commit 0ff2e9d into Kezii:master Mar 26, 2024
1 check failed
@Kezii
Copy link
Owner

Kezii commented Mar 26, 2024

ok I'll do that
thank you

@aprowe
Copy link
Contributor Author

aprowe commented Mar 27, 2024

cool!
I'm not sure if there is any overhead if the I2s Speaker interface is created but not used- If there is then probably an optional can be used to conditionally enable it.

imo a speaker abstraction layer would be pretty useful too might take a swing at that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants