Noticed a regression for Input Number while testing on webapp. Testing this logic fix #8794
SonicScrewdrivernode-ci.yml
on: pull_request
Matrix: Check for .changeset entries for all changed files
Matrix: Check builds for changes in size
Matrix: Cypress
Matrix: Lint, Typecheck, Format, and Test
Matrix: Publish npm snapshot
Annotations
10 errors
|
Check for .changeset entries for all changed files (ubuntu-latest, 20.x)
Changeset entry required for @khanacademy/perseus because there have been changes since the last release.
|
|
Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x):
packages/perseus/src/util/math.ts#L239
This comparison appears to be unintentional because the types 'MathFormat | undefined' and '"percent"' have no overlap.
|
|
Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x):
packages/perseus/src/util/parse-perseus-json/perseus-parsers/numeric-input-widget.ts#L28
Type 'Parser<WidgetOptions<"numeric-input", { answers: { message: string; value: number; status: string; answerForms: ("integer" | "mixed" | "improper" | "proper" | "decimal" | "pi" | "percent")[] | undefined; strict: boolean; maxError: number | ... 1 more ... | undefined; simplify: string | ... 1 more ... | undefined; }[...' is not assignable to type 'Parser<NumericInputWidget>'.
|
|
Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x)
Process completed with exit code 2.
|
|
Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x):
packages/perseus/src/util/math.ts#L239
This comparison appears to be unintentional because the types 'MathFormat | undefined' and '"percent"' have no overlap.
|
|
Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x):
packages/perseus/src/util/parse-perseus-json/perseus-parsers/numeric-input-widget.ts#L28
Type 'Parser<WidgetOptions<"numeric-input", { answers: { message: string; value: number; status: string; answerForms: ("integer" | "mixed" | "improper" | "proper" | "decimal" | "pi" | "percent")[] | undefined; strict: boolean; maxError: number | ... 1 more ... | undefined; simplify: string | ... 1 more ... | undefined; }[...' is not assignable to type 'Parser<NumericInputWidget>'.
|
|
Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x)
Process completed with exit code 2.
|
|
Publish npm snapshot (ubuntu-latest, 20.x):
packages/perseus/src/util/math.ts#L239
This comparison appears to be unintentional because the types 'MathFormat | undefined' and '"percent"' have no overlap.
|
|
Publish npm snapshot (ubuntu-latest, 20.x):
packages/perseus/src/util/parse-perseus-json/perseus-parsers/numeric-input-widget.ts#L28
Type 'Parser<WidgetOptions<"numeric-input", { answers: { message: string; value: number; status: string; answerForms: ("integer" | "mixed" | "improper" | "proper" | "decimal" | "pi" | "percent")[] | undefined; strict: boolean; maxError: number | ... 1 more ... | undefined; simplify: string | ... 1 more ... | undefined; }[...' is not assignable to type 'Parser<NumericInputWidget>'.
|
|
Publish npm snapshot (ubuntu-latest, 20.x)
Process completed with exit code 2.
|