-
Notifications
You must be signed in to change notification settings - Fork 350
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUGFIX - Leftmost number in Number Line widget misaligned (#1695)
## Summary: The Number Line widget contains display logic that adds duplicate endpoint numbers, and then colors them blue if the widget is being used on mobile. This duplicate endpoint becomes misaligned when styling is accounting for the reduced viewport size. This bugfix corrects that misalignment, and removes the mobile logic in favor of standardizing across all platforms (both mobile and desktop now have blue endpoints). Issue: LEMS-2383 ## Test plan: 1. Launch Storybook 1. Review the [Number Line](http://localhost:6006/?path=/story/perseus-widgets-number-line--question-1) widget - Both endpoints should be blue - All numbers on the line should be positioned the same vertically ## Affected behavior: ### Before ![Number Line Endpoint - Before](https://github.com/user-attachments/assets/951a3c2b-062f-4204-8744-03931a7c5ab4) ### After ![Number Line Endpoint - After](https://github.com/user-attachments/assets/5fcef568-85ce-4634-b862-aac9237811df) Author: mark-fitzgerald Reviewers: catandthemachines, mark-fitzgerald, #perseus Required Reviewers: Approved By: catandthemachines Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1695
- Loading branch information
1 parent
92c4e62
commit 387273b
Showing
4 changed files
with
30 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus": patch | ||
--- | ||
|
||
BUGFIX: Left-most digit in Number Line widget is misaligned |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters