Skip to content

Commit

Permalink
Remove unnecessary Z-Index for #problemarea buttons/inputs (#813)
Browse files Browse the repository at this point in the history
## Summary:
On our mobile app, we're noticing that hints are rendering above our keypad due to this style that sets the z-index to 3. I don't think we need z-index here at all as the #problemarea is only used on Mobile and in the content editor - neither of which need the index. 

Rather than using .perseus-interactive, I'm now simply setting the position directly. The relative positioning is still important to ensure that the "+" symbol appears beside the "Next Hint" button. 

Issue: LC-1445

## Test plan:
manual

Author: SonicScrewdriver

Reviewers: jeremywiebe, SonicScrewdriver

Required Reviewers:

Approved By: jeremywiebe

Checks: ⏭  Upload Coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ❌ Cypress (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: #813
  • Loading branch information
SonicScrewdriver authored Nov 24, 2023
1 parent 6d31e04 commit 691d29b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/green-ligers-roll.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": patch
---

Removing unused CSS from #problemarea.
7 changes: 0 additions & 7 deletions packages/perseus/src/styles/perseus-renderer.less
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,6 @@
}

.framework-perseus {
#problemarea {
input,
button {
.perseus-interactive;
}
}

div.paragraph {
font-family: "Lato", sans-serif;
font-weight: 400;
Expand Down

0 comments on commit 691d29b

Please sign in to comment.