Skip to content

Commit

Permalink
Remove unused rubric type
Browse files Browse the repository at this point in the history
  • Loading branch information
Myranae committed Dec 12, 2024
1 parent 8ca54d0 commit 94cbc51
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
7 changes: 0 additions & 7 deletions packages/perseus/src/validation.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ export type PerseusCategorizerValidationData = {
items: ReadonlyArray<string>;
};

// TODO(LEMS-2440): Can possibly be removed during 2440?
// This is not used for grading at all. The only place it is used is to define
// Props type in cs-program.tsx, but RenderProps already contains WidgetOptions
// and is already included in the Props type.
export type PerseusCSProgramRubric = Empty;

export type PerseusCSProgramUserInput = {
status: UserInputStatus;
message: string | null;
Expand Down Expand Up @@ -237,7 +231,6 @@ export type PerseusTableUserInput = ReadonlyArray<ReadonlyArray<string>>;

export type Rubric =
| PerseusCategorizerScoringData
| PerseusCSProgramRubric
| PerseusDropdownRubric
| PerseusExpressionRubric
| PerseusGroupRubric
Expand Down
7 changes: 2 additions & 5 deletions packages/perseus/src/widgets/cs-program/cs-program.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,14 @@ import scoreCSProgram from "./score-cs-program";

import type {PerseusCSProgramWidgetOptions} from "../../perseus-types";
import type {Widget, WidgetExports, WidgetProps} from "../../types";
import type {
PerseusCSProgramRubric,
PerseusCSProgramUserInput,
} from "../../validation.types";
import type {PerseusCSProgramUserInput} from "../../validation.types";
import type {UnsupportedWidgetPromptJSON} from "../../widget-ai-utils/unsupported-widget";

const {updateQueryString} = Util;

type RenderProps = PerseusCSProgramWidgetOptions & PerseusCSProgramUserInput;

type Props = WidgetProps<RenderProps, PerseusCSProgramRubric>;
type Props = WidgetProps<RenderProps>;

type DefaultProps = {
showEditor: Props["showEditor"];
Expand Down

0 comments on commit 94cbc51

Please sign in to comment.