Perseus Types LIES. We cannot handle the percent type in numeric input

Khan · Nov 15, 2024 · b586b71 · b586b71
1 parent d684a6e
commit b586b71
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/perseus/src/perseus-types.ts b/packages/perseus/src/perseus-types.ts
@@ -1074,7 +1074,6 @@ export type MathFormat =
     | "improper"
     | "proper"
     | "decimal"
-    | "percent"
     | "pi";
 
 export type PerseusNumericInputAnswerForm = {

diff --git a/packages/perseus/src/widgets/numeric-input/numeric-input.tsx b/packages/perseus/src/widgets/numeric-input/numeric-input.tsx
@@ -349,7 +349,11 @@ const propUpgrades = {
         // input-number to numeric-input. In this case, we need to upgrade
         // the widget options accordingly.
         if (initialProps.value) {
-            const provideAnswerForm = initialProps.answerType !== "number";
+            // If the answerType is not number or percent, we need to provide
+            // the answer form for the numeric-input widget
+            const provideAnswerForm =
+                initialProps.answerType !== "number" &&
+                initialProps.answerType !== "percent";
 
             // We need to determine the mathFormat for the numeric-input widget
             const mathFormat =