Skip to content

Commit

Permalink
remove some error suppressions
Browse files Browse the repository at this point in the history
  • Loading branch information
handeyeco committed Nov 26, 2024
1 parent 7ba21eb commit d369615
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion config/test/test-setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ if (typeof window !== "undefined") {
// Override the window.location implementation to mock out assign()
// We need to access window.location.assign to verify that we're
// redirecting to the right place.
/* eslint-disable no-restricted-syntax */
const oldLocation = window.location;
// @ts-expect-error - TS2790 - The operand of a 'delete' operator must be optional.
delete window.location;
Expand Down
1 change: 0 additions & 1 deletion packages/perseus/src/hints-renderer.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @khanacademy/ts-no-error-suppressions */
import * as PerseusLinter from "@khanacademy/perseus-linter";
import {StyleSheet, css} from "aphrodite";
import classnames from "classnames";
Expand Down
1 change: 0 additions & 1 deletion packages/perseus/src/interactive2/wrapped-drawing.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @babel/no-invalid-this */
/**
* Default methods for a wrapped movable.
*/
Expand Down
3 changes: 1 addition & 2 deletions packages/perseus/src/perseus-markdown.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable no-useless-escape, no-prototype-builtins */
import {pureMarkdownRules} from "@khanacademy/pure-markdown";
import SimpleMarkdown from "@khanacademy/simple-markdown";
import * as React from "react";
Expand Down Expand Up @@ -201,7 +200,7 @@ const rules = {
// link was not put together properly, let's make sure it's there so we
// don't break the entire page.
const isKAUrl = href
? href.match(/https?:\/\/[^\/]*khanacademy.org|^\//)
? href.match(/https?:\/\/[^/]*khanacademy.org|^\//)
: false;
if (!isKAUrl) {
// Prevents "reverse tabnabbing" phishing attacks
Expand Down
1 change: 0 additions & 1 deletion packages/perseus/src/util.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @babel/no-invalid-this, getter-return */
import {Errors, PerseusError} from "@khanacademy/perseus-core";
import _ from "underscore";

Expand Down

0 comments on commit d369615

Please sign in to comment.