Input Number Deprecation and Conversion into Numeric Input #1731

SonicScrewdriver · 2024-10-07T22:34:40Z

Summary:

This PR contains all the work necessary to deprecate our Input Number Widget, and convert it into the Numeric Input widget (sans actually deleting the Input Number Files, which will be handled in LEMS-2411).

The changes include:

Using replaceWidget/Editor to change the rendering of Input Number widgets to Numeric Input
New conversion util functions to automatically convert the json on the Editor pages for pre-existing Input Numbers in content, as an effort to avoid a backfill.
Cleanup of MANY tests across the repo that used Input Number for their test data
New PropUpgrades function for Numeric Input that converts Input Number widgetOptions into Numeric Input's format.

NOTE: There is a temporary wrapper div around the Numeric Input component in order to help QA be able to determine that the widget has been converted, as InputNumber/NumericInput are virtually identical otherwise. This will be removed prior to landing the ticket, and after QA testing has completed. This has been removed.

Screenshot

Issue: LEMS-2408 & LEMS-2409

Test plan:

Extensive Manual Testing
New Jest Tests
QA Testing Round

github-actions · 2024-10-07T22:37:20Z

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (3f29d8a) and published it to npm. You
can install it using the tag PR1731.

Example:

yarn add @khanacademy/perseus@PR1731

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1731

github-actions · 2024-10-07T22:37:28Z

Size Change: 0 B

Total Size: 872 kB

ℹ️ View Unchanged

Filename	Size
`packages/kas/dist/es/index.js`	38.9 kB
`packages/keypad-context/dist/es/index.js`	760 B
`packages/kmath/dist/es/index.js`	4.27 kB
`packages/math-input/dist/es/index.js`	77.8 kB
`packages/math-input/dist/es/strings.js`	1.79 kB
`packages/perseus-core/dist/es/index.js`	1.48 kB
`packages/perseus-editor/dist/es/index.js`	285 kB
`packages/perseus-linter/dist/es/index.js`	22.2 kB
`packages/perseus/dist/es/index.js`	420 kB
`packages/perseus/dist/es/strings.js`	3.54 kB
`packages/pure-markdown/dist/es/index.js`	3.66 kB
`packages/simple-markdown/dist/es/index.js`	12.4 kB

_{compressed-size-action}

SonicScrewdriver · 2024-10-30T19:38:37Z

packages/perseus-editor/src/editor-page.tsx

@@ -287,7 +296,7 @@ class EditorPage extends React.Component<Props, State> {
                    <ItemEditor
                        ref={this.itemEditor}
                        itemId={this.props.itemId}
-                        question={this.props.question}
+                        question={convertDeprecatedWidgets(this.props.question)}
                        answerArea={this.props.answerArea}


This could be a spicy move -- but it seems to work with editing, and I can't move the conversion logic any higher.

SonicScrewdriver · 2024-10-30T19:39:18Z

packages/perseus-editor/src/editor.tsx

@@ -31,7 +31,7 @@ import type {
    PerseusWidgetsMap,
 } from "@khanacademy/perseus";

-// like [[snowman input-number 1]]
+// like [[snowman numeric-input 1]]
 const widgetPlaceholder = "[[\u2603 {id}]]";


Not a critical change, but we might as well have our example use a widget name that will still exist after this work.

SonicScrewdriver · 2024-10-30T19:40:05Z

packages/perseus/src/index.ts

@@ -190,7 +190,8 @@ export type {
    Size,
    CollinearTuple,
    MathFormat,
-    InputNumberWidget, // TODO(jeremy): remove?
+    InputNumberWidget, // Used for usurpation of InputNumberWidget in perseus-editor
+    NumericInputWidget, // Used for usurpation of InputNumberWidget in perseus-editor
    // Widget configuration types


Note to self: I should be able to fix this if I use the PerseusWidgetMap type -- then we don't need to export these.

SonicScrewdriver · 2024-10-30T19:41:01Z

packages/perseus/src/widgets.ts

@@ -115,6 +118,8 @@ export const replaceDeprecatedEditors = () => {
    replaceEditor("sequence", "deprecated-standin");
    replaceEditor("simulator", "deprecated-standin");
    replaceEditor("unit-input", "deprecated-standin");
+
+    replaceEditor("input-number", "numeric-input");
 };


Note to self: Add comment here explaining the editor page logic so that someone can follow the trail, if this is where they start of their journey

SonicScrewdriver · 2024-10-30T19:41:58Z

packages/perseus/src/widgets.ts

        _.reject(_.keys(widgets), function (name) {
-            return widgets[name].hidden;
+            return widgets[name].hidden || name === "input-number";
        }),


We don't want to register the Input Number widget any more, as we want to remove it from the list of available widgets that Content Creators can use.

However, we ALSO want to keep the larger registration of it so that we can identify Input Number Widgets that need to be converted to Numeric Input widgets. That's why we're simply skipping input-number on this particular step.

SonicScrewdriver · 2024-10-30T19:42:20Z

packages/perseus/src/widgets/numeric-input/numeric-input.tsx

@@ -243,7 +243,7 @@ export class NumericInput
        });

        return (
-            <div>
+            <div className="Im-just-a-sweet-lil-numeric-input">


Oops, need to remove this sweet lil' guy

I'll actually be adding this back temporarily for aiding QA testing, and I will remove it prior to deploy.

SonicScrewdriver · 2024-11-05T01:28:55Z

packages/perseus-editor/src/article-editor.tsx

@@ -15,7 +15,12 @@ import SectionControlButton from "./components/section-control-button";
 import Editor from "./editor";


All changes to this file will be reverted now that we're performing the conversion in Webapp.

mark-fitzgerald · 2024-11-05T19:21:03Z

packages/perseus-editor/src/util/modernize-widgets-utils.ts

+// so that we can convert deprecated widgets to their modern equivalents when
+// content creators use the Editor Page to update content containing these widgets.
+// Currently, we're only converting input-number to numeric-input,
+// but we can add more conversions here in the future.


Absolutely LOVING the extensive explanations!!! Thank you!

mark-fitzgerald · 2024-11-05T19:23:19Z

packages/perseus-editor/src/util/modernize-widgets-utils.ts

+        if (newKey) {
+            newContent = newContent.replace(oldKey, newKey);
+        }
+    }


NIT: This could be a reduce() operation:

return Object.keys(renameMap).reduce((newContent, oldKey) => { ... }, json.content)

khan-actions-bot · 2024-11-08T17:14:56Z

Gerald

Required Reviewers

@Khan/perseus for changes to .changeset/rude-adults-lie.md, packages/perseus/src/index.ts, packages/perseus/src/perseus-types.ts, packages/perseus/src/server-item-renderer.tsx, packages/perseus/src/widgets.ts, packages/perseus-editor/src/article-editor.tsx, packages/perseus-editor/src/editor-page.tsx, packages/perseus-editor/src/editor.tsx, packages/perseus/src/__stories__/server-item-renderer.stories.tsx, packages/perseus/src/__testdata__/extract-perseus-data.testdata.ts, packages/perseus/src/__testdata__/renderer.testdata.ts, packages/perseus/src/__testdata__/server-item-renderer.testdata.ts, packages/perseus/src/__tests__/extract-perseus-data.test.ts, packages/perseus/src/__tests__/renderability.test.ts, packages/perseus/src/__tests__/renderer-api.test.tsx, packages/perseus/src/__tests__/renderer.test.tsx, packages/perseus/src/__tests__/server-item-renderer.test.tsx, packages/perseus/src/styles/styles.less, packages/perseus-editor/src/__stories__/article-editor.stories.tsx, packages/perseus-editor/src/__stories__/editor-page.stories.tsx, packages/perseus-editor/src/__tests__/traversal.test.ts, packages/perseus/src/__tests__/__snapshots__/server-item-renderer.test.tsx.snap, packages/perseus/src/__tests__/test-items/numeric-input-1-item.ts, packages/perseus/src/__tests__/test-items/numeric-input-2-item.ts, packages/perseus/src/multi-items/__testdata__/multi-renderer.testdata.ts, packages/perseus/src/multi-items/__tests__/multi-renderer.test.tsx, packages/perseus/src/widgets/input-number/input-number.testdata.ts, packages/perseus/src/widgets/numeric-input/numeric-input.tsx, packages/perseus-editor/src/util/deprecated-widgets/input-number.ts, packages/perseus-editor/src/util/deprecated-widgets/modernize-widgets-utils.test.ts, packages/perseus-editor/src/util/deprecated-widgets/modernize-widgets-utils.testdata.ts, packages/perseus-editor/src/util/deprecated-widgets/modernize-widgets-utils.ts, packages/perseus/src/multi-items/__tests__/__snapshots__/multi-renderer.test.tsx.snap, packages/perseus/src/widgets/graded-group-set/__snapshots__/graded-group-set-jipt.test.ts.snap, packages/perseus/src/widgets/graded-group-set/__snapshots__/graded-group-set.test.ts.snap, packages/perseus/src/widgets/group/__snapshots__/group.test.tsx.snap, packages/perseus/src/widgets/numeric-input/__snapshots__/numeric-input.test.ts.snap

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

mark-fitzgerald · 2024-11-08T23:27:32Z

packages/perseus-editor/src/article-editor.tsx

+            : [this.state.json];
+        return sections.filter(
+            (section): section is PerseusRenderer => section !== null,
+        );


Nit: Perhaps this could use nullish coalescence?

_sections(): PerseusRenderer[] { return Array.isArray(this.state.json) ? (this.state.json ?? []) : [this.state.json]; };

mark-fitzgerald · 2024-11-08T23:35:27Z

packages/perseus-editor/src/article-editor.tsx

@@ -350,7 +362,7 @@ export default class ArticleEditor extends React.Component<Props, State> {
        const newSection =
            i >= 0
                ? {
-                      widgets: sections[i].widgets,
+                      widgets: sections![i].widgets,


Shouldn't this be a question mark instead of an exclamation point?

I'm fixing this one by getting rid if the silly local type that's faking the PerseusRenderer.

mark-fitzgerald · 2024-11-08T23:46:23Z

packages/perseus-editor/src/util/modernize-widgets-utils.ts

+// Modernize the json content of a PerseusRenderer object
+// by converting deprecated widgets to their modern equivalents
+export const convertDeprecatedWidgets = (
+    json: PerseusRenderer,


Since json can be null/undefined, shouldn't this technically be:

json: PerseusRenderer | null | undefined,

mark-fitzgerald · 2024-11-08T23:52:05Z

packages/perseus-editor/src/editor-page.tsx

+        let convertedQuestionJson: PerseusRenderer = props.question;
+        if (props.question) {
+            convertedQuestionJson = convertDeprecatedWidgets(props.question);
+        }


Since convertDeprecatedWidgets takes null/undefined as a parameter option, couldn't this be simplified to:

const convertedQuestionJson = convertDeprecatedWidgets(props.question);

Hmm open to feedback on this one!

The approach I've taken (in my upcoming updates) has been to ensure we're only ever calling convertQuestionJson if we already have the data. Otherwise we need a TON of null checks across our code. I've updated convertDeprecatedWidgets to no longer return null

mark-fitzgerald · 2024-11-08T23:57:08Z

packages/perseus-editor/src/editor-page.tsx

-                "itemDataVersion",
-            ),
+            json: json,
+            question: json.question,


I'm not seeing where this.state.question is used elsewhere. Can you point me to where it is used? I'm also wonder if it needs to be updated in changeJSON.

Whoops, thank you for catching this! It's a vestige of an old approach to fixing the json. Removed!

mark-fitzgerald · 2024-11-09T00:16:25Z

packages/perseus-editor/src/util/modernize-widgets-utils.ts

+export const convertDeprecatedWidgets = (
+    json: PerseusRenderer,
+): PerseusRenderer => {
+    // If there's no json, or no input-number widgets, then we can return the json as is


Nit: Maybe generalize the explanation to "If there's no json, or no widgets to convert, then we can return the json as is"

mark-fitzgerald · 2024-11-09T00:32:23Z

packages/perseus-editor/src/util/modernize-widgets-utils.ts

+    // Check the content string for any top-level input-number widgets
+    if (inputNumberRegex.test(json.content)) {
+        return true;
+    }


This might be over-engineering, but to aid in possible future conversions, what do you think about setting things up this way:

const widgetRegExes = [/input-number \d+/]; // Add your widget expression here if (widgetRegExes.some(regex => regex.test(json.content))) { return true; }

mark-fitzgerald · 2024-11-09T00:36:43Z

packages/perseus-editor/src/util/modernize-widgets-utils.ts

+        return true;
+    }
+
+    // If there's no input-numbers top-level, then check the widgets for any nested widgets


Nit: Generic comment here, too?
"If there's no deprecated widget in the top-level, then check for any nested widgets"

mark-fitzgerald · 2024-11-09T00:42:10Z

packages/perseus-editor/src/util/modernize-widgets-utils.ts

+        if (newKey) {
+            return newContent.replace(oldKey, newKey);
+        }
+        return newContent;


Nit: Ternary operator?

return newKey ? newContent.replace(oldKey, newKey) : newContent;

…e files, and temporary addition of a new div to help QA be able to tell we've swapped to the new widget.

- Refactoring of a ton of tests across Perseus to remove Input Number - Pre-work for removing references to Input Number all together + stashed proof of concept that we're safe to go - Refactoring of the ArticleEditor so that we can keep the conversion "in house" - Addition of div around numeric input to support QA testing (will be removed after testing)

…ber test file.

mark-fitzgerald

Super well-organized!! Thanks for all the documentation, too.

@SonicScrewdriver

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#1731](#1731) [`27126aa00`](27126aa) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Conversion of Input Number to Numeric Input ### Patch Changes - [#1846](#1846) [`8eb1ff5d1`](8eb1ff5) Thanks [@benchristel](https://github.com/benchristel)! - Internal: add widget parsers for ADR 773. - [#1839](#1839) [`150888870`](1508888) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Figure Labels] Util function to generate spoken math + use it within Locked Point aria labels ## @khanacademy/[email protected] ### Minor Changes - [#1859](#1859) [`dcf1fbe35`](dcf1fbe) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Addition of a new alert for the content editors when Input numbers are converted to Numeric Inputs - [#1731](#1731) [`27126aa00`](27126aa) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Conversion of Input Number to Numeric Input ### Patch Changes - [#1839](#1839) [`150888870`](1508888) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Figure Labels] Util function to generate spoken math + use it within Locked Point aria labels - Updated dependencies \[[`8eb1ff5d1`](8eb1ff5), [`150888870`](1508888), [`27126aa00`](27126aa)]: - @khanacademy/[email protected]

…1731)" This reverts commit 27126aa.

@SonicScrewdriver

… logic (#1905) ## Summary: In order to unblock Perseus, we are reverting the following commits: - [x] [#1888](#1888) [d0e7a03](d0e7a03) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fixing issue with Input Numbers that have a value of 0 - [x] [#1884](#1884) [b4cf444](b4cf444) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Ensuring UserInput and Rubric widget keys match for edge cases - [x] [#1879](#1879) [04d6e60](04d6e60) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fixing conflicts that arose from scoring and widget conversion efforts - [x] [#1753](#1753) [c1ba55f](c1ba55f) Thanks [@handeyeco](https://github.com/handeyeco)! - Change ServerItemRenderer scoring APIs to externalize scoring - [x] [#1866](#1866) [94eba15](94eba15) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fixing a regression and a bug in the Input Conversion Logic - [x] [#1859](#1859) [dcf1fbe](dcf1fbe) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Addition of a new alert for the content editors when Input numbers are converted to Numeric Inputs - [x] [#1731](#1731) [27126aa](27126aa) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Conversion of Input Number to Numeric Input ## Test plan: - manual testing Author: SonicScrewdriver Reviewers: catandthemachines, #perseus Required Reviewers: Approved By: catandthemachines Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald, 🚫 Publish npm snapshot (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), ✅ gerald, ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1905

@SonicScrewdriver

… logic (#1905) ## Summary: In order to unblock Perseus, we are reverting the following commits: - [x] [#1888](#1888) [d0e7a03](d0e7a03) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fixing issue with Input Numbers that have a value of 0 - [x] [#1884](#1884) [b4cf444](b4cf444) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Ensuring UserInput and Rubric widget keys match for edge cases - [x] [#1879](#1879) [04d6e60](04d6e60) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fixing conflicts that arose from scoring and widget conversion efforts - [x] [#1753](#1753) [c1ba55f](c1ba55f) Thanks [@handeyeco](https://github.com/handeyeco)! - Change ServerItemRenderer scoring APIs to externalize scoring - [x] [#1866](#1866) [94eba15](94eba15) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fixing a regression and a bug in the Input Conversion Logic - [x] [#1859](#1859) [dcf1fbe](dcf1fbe) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Addition of a new alert for the content editors when Input numbers are converted to Numeric Inputs - [x] [#1731](#1731) [27126aa](27126aa) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Conversion of Input Number to Numeric Input ## Test plan: - manual testing Author: SonicScrewdriver Reviewers: catandthemachines, #perseus Required Reviewers: Approved By: catandthemachines Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald, 🚫 Publish npm snapshot (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), ✅ gerald, ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1905

SonicScrewdriver self-assigned this Oct 7, 2024

SonicScrewdriver changed the title ~~Initial Prototype for testing on webapp~~ Initial Input Number Deprecation Prototype for testing on webapp Oct 7, 2024

SonicScrewdriver force-pushed the numeric-usurpation branch from 1336a33 to c38dc8c Compare October 9, 2024 21:13

SonicScrewdriver force-pushed the numeric-usurpation branch from 021b83b to a861d59 Compare October 30, 2024 19:32

SonicScrewdriver commented Oct 30, 2024

View reviewed changes

SonicScrewdriver commented Nov 5, 2024

View reviewed changes

mark-fitzgerald reviewed Nov 5, 2024

View reviewed changes

SonicScrewdriver force-pushed the numeric-usurpation branch from 53eedb9 to a398605 Compare November 6, 2024 00:14

SonicScrewdriver changed the title ~~Initial Input Number Deprecation Prototype for testing on webapp~~ Input Number Deprecation and Conversion into Numeric Input Nov 7, 2024

SonicScrewdriver marked this pull request as ready for review November 8, 2024 17:14

khan-actions-bot requested a review from a team November 8, 2024 17:14

SonicScrewdriver force-pushed the numeric-usurpation branch from 512ed24 to 5221038 Compare November 8, 2024 18:13

mark-fitzgerald reviewed Nov 8, 2024

View reviewed changes

mark-fitzgerald reviewed Nov 9, 2024

View reviewed changes

SonicScrewdriver added 14 commits November 14, 2024 10:51

Cleaning up some earlier changes, better organization of the moderniz…

b55035e

…e files, and temporary addition of a new div to help QA be able to tell we've swapped to the new widget.

Removing input-number test rather than updating.

6dcfe33

Removing old snapshot

641cdad

Fixing the state for articles

efa04eb

Fixing keys

3063116

Updating class

717e7d9

Fixing a bug

9b7b956

Fixing tests after fixing bug

0f8e4d0

Addressing PR Feedback + Bugfix for LEMS-2613

987f34f

Undoing export

142cc3e

Removing new code added for deprecated widget to unblock PR

fa335c0

Undoing this one file but keeping the tests deleted.

31d1397

Addressing PR Feedback + Fixing merge conflict with deleted input-num…

079fcfa

…ber test file.

SonicScrewdriver force-pushed the numeric-usurpation branch from 9851e9d to 079fcfa Compare November 14, 2024 18:53

khan-actions-bot requested a review from a team November 14, 2024 18:54

Removing this sweet lil' guy now that QA testing is complete

3cccf4e

mark-fitzgerald approved these changes Nov 14, 2024

View reviewed changes

Whoops this is not necessary any more

c4e93af

khan-actions-bot requested a review from a team November 14, 2024 19:03

SonicScrewdriver added 2 commits November 14, 2024 11:10

Updated snapshots

1fc4ea3

Whoops, we missed bringing over the logic upgrades for answerforms.

3f29d8a

SonicScrewdriver merged commit 27126aa into main Nov 14, 2024
8 of 9 checks passed

SonicScrewdriver deleted the numeric-usurpation branch November 14, 2024 20:44

khan-actions-bot mentioned this pull request Nov 14, 2024

Version Packages #1857

Merged

SonicScrewdriver added a commit that referenced this pull request Nov 22, 2024

Revert "Input Number Deprecation and Conversion into Numeric Input (#…

fd7caeb

…1731)" This reverts commit 27126aa.

SonicScrewdriver mentioned this pull request Nov 22, 2024

Reverting all Server Side Scoring and Input Number conversion Project logic #1905

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Input Number Deprecation and Conversion into Numeric Input #1731

Input Number Deprecation and Conversion into Numeric Input #1731

SonicScrewdriver commented Oct 7, 2024 •

edited

Loading

github-actions bot commented Oct 7, 2024 •

edited

Loading

github-actions bot commented Oct 7, 2024 •

edited

Loading

SonicScrewdriver Oct 30, 2024

SonicScrewdriver Oct 30, 2024

SonicScrewdriver Oct 30, 2024

SonicScrewdriver Oct 30, 2024

SonicScrewdriver Oct 30, 2024 •

edited

Loading

SonicScrewdriver Oct 30, 2024

SonicScrewdriver Nov 5, 2024

SonicScrewdriver Nov 5, 2024

mark-fitzgerald Nov 5, 2024

mark-fitzgerald Nov 5, 2024 •

edited

Loading

khan-actions-bot commented Nov 8, 2024 •

edited

Loading

mark-fitzgerald Nov 8, 2024

mark-fitzgerald Nov 8, 2024

SonicScrewdriver Nov 12, 2024

mark-fitzgerald Nov 8, 2024

mark-fitzgerald Nov 8, 2024

SonicScrewdriver Nov 12, 2024 •

edited

Loading

mark-fitzgerald Nov 8, 2024

SonicScrewdriver Nov 12, 2024

mark-fitzgerald Nov 9, 2024

mark-fitzgerald Nov 9, 2024

mark-fitzgerald Nov 9, 2024

mark-fitzgerald Nov 9, 2024

mark-fitzgerald left a comment

		@@ -15,7 +15,12 @@ import SectionControlButton from "./components/section-control-button";
		import Editor from "./editor";

Input Number Deprecation and Conversion into Numeric Input #1731

Input Number Deprecation and Conversion into Numeric Input #1731

Conversation

SonicScrewdriver commented Oct 7, 2024 • edited Loading

Summary:

Screenshot

Test plan:

github-actions bot commented Oct 7, 2024 • edited Loading

npm Snapshot: Published

github-actions bot commented Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SonicScrewdriver Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mark-fitzgerald Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

khan-actions-bot commented Nov 8, 2024 • edited Loading

Gerald

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SonicScrewdriver Nov 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mark-fitzgerald left a comment

Choose a reason for hiding this comment

SonicScrewdriver commented Oct 7, 2024 •

edited

Loading

github-actions bot commented Oct 7, 2024 •

edited

Loading

github-actions bot commented Oct 7, 2024 •

edited

Loading

SonicScrewdriver Oct 30, 2024 •

edited

Loading

mark-fitzgerald Nov 5, 2024 •

edited

Loading

khan-actions-bot commented Nov 8, 2024 •

edited

Loading

SonicScrewdriver Nov 12, 2024 •

edited

Loading