Expose a way to get user input from ServerItemRenderer #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
handeyeco
changed the title
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f8a1b06) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1910If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1910 |
|
Size Change: +577 B (+0.04%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
handeyeco
changed the title
jeremywiebe
approved these changes
Nov 27, 2024
| @@ -39,7 +105,7 @@ describe("emptyWidgetsFunctional", () => { | |||
| it("properly identifies empty widgets", () => { | |||
| // Arrange | |||
| const widgets: PerseusWidgetsMap = { | |||
| "dropdown 1": testDropdownWidget, | |||
| "dropdown 1": getTestDropdownWidget(), | |||
There was a problem hiding this comment.
Why did this need to become a function?
There was a problem hiding this comment.
I used a function for the new tests, so I changed the old one to be consistent with the new one.
IMO it's better to use a function because it ensures tests are as isolated as possible. Using the same object for multiple tests means one test can mutate the object that is then passed to another test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a repeat of PR #1753 (which was reverted in #1905)
While this PR is essentially the same as the previous one, I added prop upgrading to the scoring logic and the empty widget logic (along with some tests).
I'm trying to tread lightly, maybe being overly cautious at the expense of keeping too much old code around. I tried to make everything we can get rid of after the move with
@deprecated.Basically this should expose everything we need to move the actual scoring process out of ServerItemRenderer and the React tree. We now have
getUserInputonServerItemRendererandscorePerseusItemwhich is a non-React, pure function that returns a score.Next step is to replace uses of
scoreInputin Webapp withscorePerseusItem; then we can come back and delete a lot of this legacy code 🤞Issue: LEMS-2665
Test plan:
After the swap in Webapp, we should be able to complete an exercise with
scorePerseusItemand everything else will work the same.