Update TypeScript to version 5.7.2 #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (de2e40a) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1929If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1929 |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
jeremywiebe
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Nice. We're moving to Storybook 8 next week also: #1904
Thanks for this!
jeremywiebe
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Wonder Blocks is updating Storybook to 8.x which requires using "moduleResolution": "bundler" in its tsconfig, see https://stackoverflow.com/questions/72193784/why-doesnt-the-exports-field-of-npm-work-in-typescript for details. To fix this, I decided to update TypeScript in Wonder Blocks. Instead of updating to the minimally required version I figured I may as well upgrade to the most recent version since I'm upgrading anyways.
Although we probably don't need to update TypeScript in all of our repos at the same time (unless we start using new syntax), we may as well. That way, if a new Wonder Blocks package is published with new TS syntax it its types, Perseus will be ready.
In theory, this shouldn't change the output of any of the packages since we're using babel for compilation.
Issue: None
Test plan: