-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MultiRenderer #1955
Remove MultiRenderer #1955
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: -20.1 kB (-1.56%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting to drop support for these MultiItems.
Not sure if we want to, but I think we can delete the data/item-missing-answerArea.json
parsing test file and its associated snapshot too then.
packages/perseus-editor/src/i18n.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see these used anywhere. Can we delete these too?
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f2225a0) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1955 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1955 |
Summary:
GTP is dead and MultiRenderer existed for GTP. Removing it simplifies things quite a bit.
Issue: LEMS-2675
Test plan:
Shouldn't affect anything, no longer in use