Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MultiRenderer #1955

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Remove MultiRenderer #1955

merged 8 commits into from
Dec 11, 2024

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Dec 5, 2024

Summary:

GTP is dead and MultiRenderer existed for GTP. Removing it simplifies things quite a bit.

Issue: LEMS-2675

Test plan:

Shouldn't affect anything, no longer in use

@handeyeco handeyeco self-assigned this Dec 5, 2024
@handeyeco handeyeco changed the title bulk of it removed, tests passing Remove MultiItem Dec 5, 2024
@handeyeco handeyeco changed the title Remove MultiItem Remove MultiRenderer Dec 5, 2024
@handeyeco handeyeco marked this pull request as ready for review December 5, 2024 20:48
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Dec 5, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/cool-taxis-clap.md, docs/architecture.md, packages/perseus/src/a11y.ts, packages/perseus/src/index.ts, packages/perseus/src/perseus-types.ts, packages/perseus/src/renderability.ts, packages/perseus/src/types.ts, packages/perseus/src/widget-type-utils.ts, packages/perseus-editor/src/index.ts, packages/perseus/src/__tests__/a11y.test.ts, packages/perseus/src/__tests__/renderability.test.ts, packages/perseus-editor/src/components/graph-settings.tsx, packages/perseus-editor/src/widgets/interactive-graph-editor/components/interactive-graph-settings.tsx, packages/perseus/src/util/parse-perseus-json/regression-tests/__snapshots__/parse-perseus-json-snapshot.test.ts.snap

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team December 5, 2024 20:48
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Size Change: -20.1 kB (-1.56%)

Total Size: 1.27 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 688 kB -9.48 kB (-1.36%)
packages/perseus/dist/es/index.js 415 kB -10.6 kB (-2.5%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.7 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Copy link
Collaborator

@jeremywiebe jeremywiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting to drop support for these MultiItems.

Not sure if we want to, but I think we can delete the data/item-missing-answerArea.json parsing test file and its associated snapshot too then.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these used anywhere. Can we delete these too?

Copy link
Contributor

github-actions bot commented Dec 6, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (f2225a0) and published it to npm. You
can install it using the tag PR1955.

Example:

yarn add @khanacademy/perseus@PR1955

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1955

@handeyeco handeyeco merged commit e7b4db0 into main Dec 11, 2024
9 checks passed
@handeyeco handeyeco deleted the rm-multirenderer branch December 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants