Update yarn.lock after browserslist update broke it #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4ccea56) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1957If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1957 |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jeremywiebe
added a commit
that referenced
this pull request
Dec 5, 2024
## Summary: The last release failed because the `yarn.lock` file was changed when `yarn install` ran (See #1957). This PR reverses (`git revert 5963ea1`) the release commit so that we can get a new Version Packages PR and land it (and trigger a new release). <img width="932" alt="image" src="https://github.com/user-attachments/assets/81227009-bb4f-4638-9b0b-258e97879c8b"> PR #1957 must be landed after this PR, but _before_ we do a release. Issue: "none" ## Test plan: Author: jeremywiebe Reviewers: mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ❌ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald, ✅ gerald, ❌ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1958
mark-fitzgerald
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This morning I landed a farily benign PR that is generated periodically to update our browserslist reference. After landing it, it appears that running
yarn installintroduces changes to theyarn.lockfile.This PR was created by running
yarn installlocally on a clean repo and committing the changesyarnmade.The reason is not clear yet, but this PR applies the changes that
yarnwants so thatmaincan be clean again.Issue: "none"
Test plan:
yarn installGit repo is still clean