Upgrade ESLint and @typescript-eslint to remove lint warning #1971
Conversation
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (ed363a9) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1971If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1971 |
|
Size Change: +317 B (+0.02%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
| @@ -228,7 +227,7 @@ class MathInput extends React.Component<Props, State> { | |||
| // in which case we don't want to dismiss the keypad on check. | |||
| if (!isWithinKeypadBounds(x, y)) { | |||
| this.blur(); | |||
| this.props.onBlur && this.props.onBlur(); | |||
| this.props.onBlur?.(); | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-expressions | ||
| piece.content.length > 1 | ||
| ? (convertedSpeech += piece.content.slice(1)) | ||
| : (convertedSpeech += piece.content); |
There was a problem hiding this comment.
You can configure @typescript-eslint/no-unused-expressions to allow ternaries if you want, see https://eslint.org/docs/latest/rules/no-unused-expressions#options.
There was a problem hiding this comment.
I find assignment within a ternary to be pretty difficult to maintain/understand. I re-worked this slightly.
@nishasy for visibility as you wrote this. What do you think of transforming what you wrote to:
convertedSpeech +=
piece.content.length > 1
? piece.content.slice(1)
: piece.content;
There was a problem hiding this comment.
@jeremywiebe Good point! I like it 🚀
| } catch { | ||
| return "unknown"; | ||
| } |
There was a problem hiding this comment.
I didn't realize this syntax was support. Nice!
Summary:
This PR bumps @typescript-eslint/* to v8.18.0 and ESLint to v8.57.1 to suppress a new lint warning after bumping @khanacademy/eslint-plugin from v3.0.0 to v3.0.1.
The warning looked like this:
Issue: FEI-6012
Test plan:
$ yarn --check-files; yarn lintno warnings about TypeScript versions