[Locked Figures Aria] Update the auto-generated text to spell out commas #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All our interactive graph aria labels are spelling out commas in coordinate pairs for clarity. When using a coordinate pair as is, the screen reader may skip the comma and read ambiguously. Example: (1000, 975) ==> "one thousand nine hundred seventy-five" (sounds like 1975) To fix this issue and be consistent with all the other interactive graph aria labels, the locked labels' autogeneration should also spell out commas. - Spell out commas in locked figures' auto-generated aria label text Issue: none Test plan: `yarn jest --silent` Storybook - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-figure-labels-all-flags - Go through all the different locked figures and click "auto-generate" - Note that their coordinates should all spell out the comma within the auto-generated text - Do this for point, line, vector, ellipse, and polygon (not function or label)
|
Size Change: +21 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9b1d579) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1976If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1976 |
anakaren-rojas
approved these changes
Dec 10, 2024
Merged
nishasy
added a commit
that referenced
this pull request
Dec 10, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#1966](#1966) [`e22a931d9`](e22a931) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Numeric Input] - BUGFIX - Adjust color contrast of tooltip text ## @khanacademy/[email protected] ### Patch Changes - [#1976](#1976) [`2ad163b5e`](2ad163b) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Figures Aria] Update the auto-generated text to spell out commas - Updated dependencies \[[`e22a931d9`](e22a931)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
All our interactive graph aria labels are spelling out commas
in coordinate pairs for clarity. When using a coordinate pair
as is, the screen reader may skip the comma and read
ambiguously.
Example: (1000, 975) ==> "one thousand nine hundred seventy-five" (sounds like 1975)
To fix this issue and be consistent with all the other
interactive graph aria labels, the locked labels' autogeneration
should also spell out commas.
Issue: none
Test plan:
yarn jest --silentStorybook
the auto-generated text