-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap out deprecated input-number with numeric-input in some tests #1995
Swap out deprecated input-number with numeric-input in some tests #1995
Conversation
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4efe639) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1995 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1995 |
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
149c7b0
to
7497676
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these changes are just in test related content, right? So it shouldn't touch the user experience at all? Does this conflict with the efforts to automatically swap these two widgets? My guess is no, but wanted to see if that needed to be considered at all.
7497676
to
f4887c9
Compare
Correct! They are strictly tests and getting rid of a widget that is deprecated and scheduled for removal.
No, that initiative is currently paused as we look at a backfill instead. |
Subject
The
input-number
widget is deprecated and was causing issues in the work I'm doing for validation and SSS. Swapping them out for thenumeric-input
so that I have a path forward.Test Plan
yarn test
yarn typecheck
Issue: LEMS-2561