Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out deprecated input-number with numeric-input in some tests #1995

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

jeremywiebe
Copy link
Collaborator

Subject

The input-number widget is deprecated and was causing issues in the work I'm doing for validation and SSS. Swapping them out for the numeric-input so that I have a path forward.

Test Plan

yarn test
yarn typecheck

Issue: LEMS-2561

@jeremywiebe jeremywiebe self-assigned this Dec 12, 2024
@jeremywiebe jeremywiebe marked this pull request as ready for review December 12, 2024 20:15
Copy link
Contributor

github-actions bot commented Dec 12, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (4efe639) and published it to npm. You
can install it using the tag PR1995.

Example:

yarn add @khanacademy/perseus@PR1995

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1995

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Size Change: 0 B

Total Size: 1.27 MB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 688 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 416 kB
packages/perseus/dist/es/strings.js 4.12 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@jeremywiebe jeremywiebe changed the base branch from jer/client-validation-1 to main December 13, 2024 00:07
@jeremywiebe jeremywiebe force-pushed the jer/client-validation-2 branch from 149c7b0 to 7497676 Compare December 13, 2024 00:27
Copy link
Contributor

@Myranae Myranae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these changes are just in test related content, right? So it shouldn't touch the user experience at all? Does this conflict with the efforts to automatically swap these two widgets? My guess is no, but wanted to see if that needed to be considered at all.

@jeremywiebe jeremywiebe changed the base branch from main to feature/client-validation December 13, 2024 21:08
@jeremywiebe jeremywiebe force-pushed the jer/client-validation-2 branch from 7497676 to f4887c9 Compare December 13, 2024 21:09
@jeremywiebe
Copy link
Collaborator Author

Looks like these changes are just in test related content, right? So it shouldn't touch the user experience at all?

Correct! They are strictly tests and getting rid of a widget that is deprecated and scheduled for removal.

Does this conflict with the efforts to automatically swap these two widgets? My guess is no, but wanted to see if that needed to be considered at all.

No, that initiative is currently paused as we look at a backfill instead.

@jeremywiebe jeremywiebe merged commit 99cd254 into feature/client-validation Dec 13, 2024
8 checks passed
@jeremywiebe jeremywiebe deleted the jer/client-validation-2 branch December 13, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants