Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "grid" role from keypad #760

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Remove "grid" role from keypad #760

merged 3 commits into from
Oct 11, 2023

Conversation

nedredmond
Copy link
Contributor

LC-1356

Removes "grid" role from keypad. Its presence without "row" and "gridcell" roles in child elements muddles the screen reader experience.

@khan-actions-bot khan-actions-bot requested a review from a team October 11, 2023 15:18
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 11, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/lemon-bears-remain.md, packages/math-input/src/components/keypad/keypad.tsx, packages/math-input/src/components/keypad/__tests__/__snapshots__/keypad.test.tsx.snap

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (42ab4e8) and published it to npm. You
can install it using the tag PR760.

Example:

yarn add @khanacademy/perseus@PR760

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Size Change: -7 B (0%)

Total Size: 850 kB

Filename Size Change
packages/math-input/dist/es/index.js 104 kB -7 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.25 kB
packages/perseus-core/dist/es/index.js 934 B
packages/perseus-editor/dist/es/index.js 268 kB
packages/perseus-error/dist/es/index.js 846 B
packages/perseus-linter/dist/es/index.js 21.4 kB
packages/perseus/dist/es/index.js 396 kB
packages/pure-markdown/dist/es/index.js 3.77 kB
packages/simple-markdown/dist/es/index.js 12.3 kB

compressed-size-action

Copy link
Contributor

@handeyeco handeyeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@nedredmond nedredmond merged commit 7d8905b into main Oct 11, 2023
9 checks passed
@nedredmond nedredmond deleted the ned/lc-1356 branch October 11, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants