Two column support in Perseus #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a proof of concept for allowing Perseus to render only
a single column when the content contains two columns. The idea is that
the containing page would render two separate `ServerItemRenderer`
components, one for each column. It could then control how each column
is laid out.
Example code:
```
<div class="column-wrapper">
<div class="left-column">
<ServerItemRenderer
item={item}
apiOptions={{renderColumn: "left"}} />
</div>
<div class="right-column">
<ServerItemRenderer
item={item}
apiOptions={{renderColumn: "right"}} />
</div>
</div>
```
If the question has hints, we don't want them to appear with the passage in the left column. This commit excludes hints if the calling code specifies that only the left column should be rendered.
|
Size Change: +76 B (0%) Total Size: 852 kB
ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 59.63% 60.92% +1.29%
==========================================
Files 480 482 +2
Lines 105413 105447 +34
Branches 6031 8714 +2683
==========================================
+ Hits 62860 64243 +1383
+ Misses 42553 41204 -1349
... and 43 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Closed! Discussed with the Perseus team and we decided on a different solution. Currently implemented in webapp here: https://github.com/Khan/webapp/pull/17851. May be moved into Perseus when grouped assessment items are supported in mobile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Mastery-enabled Long Passage Practice project will introduce a two column layout for certain exercises, specifically long passages that have 4-5 questions associated with them. The user will see two columns with the passage on the left side and the questions on the right side.
To achieve this new UI, this PR introduces an update to the
ServerItemRendererto addrenderColumnto theapiOptions, so thatExerciseChromein the content library can control how to display each column.Issue: CL-1121
Test plan:
Storybook:
http://localhost:6006/?path=/story/perseus-renderers-server-item-renderer--sat-passage-item-left-column
http://localhost:6006/?path=/story/perseus-renderers-server-item-renderer--sat-passage-item-right-column