Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing all instances of useV2Keypad #794

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

SonicScrewdriver
Copy link
Contributor

@SonicScrewdriver SonicScrewdriver commented Nov 8, 2023

Summary:

Now that we've fully moved towards our v2keypad everywhere in webapp, we can remove the useV2Keypad from the keypad apiOptions. I also removed some errant keypad types that are no longer used: MATH_INPUT_KEYPAD_V1 and PERSEUS_MATH_INPUT. We'll also be able to clean this code up even further with this future ticket.

Issue: LC-1088

Test plan:

manual+automatic testing

@SonicScrewdriver SonicScrewdriver self-assigned this Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Size Change: -120 B (0%)

Total Size: 831 kB

Filename Size Change
packages/perseus/dist/es/index.js 401 kB -120 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.25 kB
packages/math-input/dist/es/index.js 78.7 kB
packages/perseus-core/dist/es/index.js 907 B
packages/perseus-editor/dist/es/index.js 269 kB
packages/perseus-error/dist/es/index.js 878 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/pure-markdown/dist/es/index.js 3.77 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #794 (dda3cd2) into main (3cf5ac4) will increase coverage by 1.31%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
+ Coverage   61.33%   62.65%   +1.31%     
==========================================
  Files         405      407       +2     
  Lines       99429    99434       +5     
  Branches     6065     8559    +2494     
==========================================
+ Hits        60989    62300    +1311     
+ Misses      38440    37134    -1306     

Impacted file tree graph

Files Coverage Δ
packages/perseus-core/src/analytics.ts 0.00% <ø> (ø)
packages/perseus/src/perseus-api.tsx 100.00% <ø> (ø)
packages/perseus/src/widgets/expression.tsx 93.17% <100.00%> (-0.04%) ⬇️

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf5ac4...dda3cd2. Read the comment docs.

@SonicScrewdriver SonicScrewdriver marked this pull request as ready for review November 8, 2023 23:06
@khan-actions-bot khan-actions-bot requested a review from a team November 8, 2023 23:06
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Nov 8, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/grumpy-humans-jump.md, packages/perseus/src/perseus-api.tsx, packages/perseus/src/types.ts, packages/perseus-core/src/analytics.ts, packages/perseus/src/widgets/expression.tsx, packages/perseus/src/widgets/__stories__/expression.stories.tsx, packages/perseus/src/widgets/__tests__/expression-mobile.test.tsx, packages/perseus/src/widgets/__tests__/expression.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@SonicScrewdriver
Copy link
Contributor Author

SonicScrewdriver commented Nov 8, 2023

Edited: I had a question about removing keypad-legacy as it's no longer used, but we've determined it's better to remove that at a later date. The minor codecov complaint can be ignored. :)

@@ -89,7 +89,7 @@ class ProvidedKeypad extends React.Component<Props> implements KeypadAPI {
this.props.onAnalyticsEvent({
type: "math-input:keypad-opened",
payload: {
virtualKeypadVersion: "MATH_INPUT_KEYPAD_V1",
virtualKeypadVersion: "MATH_INPUT_KEYPAD_V2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think we should leave this unchanged until we actually remove the v1 keypad. This file is part of the v1 keypad so it feels really weird to be keeping this analytics event but firing the wrong virtualKeypadVersion in it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremywiebe @SonicScrewdriver v1 keypad has been removed as of this PR. Can we land this PR?

Copy link
Contributor

github-actions bot commented Dec 4, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (dda3cd2) and published it to npm. You
can install it using the tag PR794.

Example:

yarn add @khanacademy/perseus@PR794

@SonicScrewdriver SonicScrewdriver merged commit a91c84f into main Dec 4, 2023
13 checks passed
@SonicScrewdriver SonicScrewdriver deleted the removing-usev2keypad branch December 4, 2023 22:04
@khan-actions-bot khan-actions-bot mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants