Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "do not track" query parameter to vimeo links in the video widget to ensure tracking/analytics cookies don't get set. #795

Merged
merged 3 commits into from
Nov 14, 2023

add unit tests

d936786
Select commit
Loading
Failed to load commit list.
Merged
Codecov / codecov/project succeeded Nov 9, 2023 in 0s

61.93% (+1.25%) compared to f124ef9

View this Pull Request on Codecov

61.93% (+1.25%) compared to f124ef9

Details

Codecov Report

Merging #795 (d936786) into main (f124ef9) will increase coverage by 1.25%.
Report is 2 commits behind head on main.
The diff coverage is 81.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
+ Coverage   60.68%   61.93%   +1.25%     
==========================================
  Files         483      485       +2     
  Lines      105876   105881       +5     
  Branches     6225     8920    +2695     
==========================================
+ Hits        64249    65577    +1328     
+ Misses      41627    40304    -1323     

Impacted file tree graph

Files Coverage Δ
packages/perseus/src/widgets/video.tsx 87.40% <81.81%> (+0.31%) ⬆️

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f124ef9...d936786. Read the comment docs.