Update the color of rationales #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2023 15:07
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (2783153) and published it to npm. You Example: yarn add @khanacademy/perseus@PR797 |
|
Size Change: +117 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
+ Coverage 60.67% 61.93% +1.25%
==========================================
Files 483 486 +3
Lines 105853 105898 +45
Branches 6225 8918 +2693
==========================================
+ Hits 64226 65586 +1360
+ Misses 41627 40312 -1315
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jeremywiebe
approved these changes
Nov 15, 2023
| @@ -346,6 +346,7 @@ const styles = StyleSheet.create({ | |||
| padding: intermediateCheckboxPadding, | |||
| paddingTop: 0, | |||
| marginLeft: 54, | |||
| color: Color.offBlack64, | |||
There was a problem hiding this comment.
There are two references to rationales in our .less styles:
These are in Article styles. Just wanted to check if you verified this in Articles. The styles you've added here likely override those .less styles, but it might be useful to clean them up just so we don't introduce a regression at some point in the future if we move this color style for some reason.
There was a problem hiding this comment.
I'm nervous to take these out because I'm afraid of strange CSS-at-a-distance meaning that these are used in ways I don't understand in prod.
Merged
jeremywiebe
pushed a commit
that referenced
this pull request
Nov 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#811](#811) [`bca527ab`](bca527a) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Bump all Wonder Blocks dependencies to latest ## @khanacademy/[email protected] ### Minor Changes - [#797](#797) [`021f9462`](021f946) Thanks [@nixterrimus](https://github.com/nixterrimus)! - Change the rational color in radio widget - [#811](#811) [`bca527ab`](bca527a) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Bump all Wonder Blocks dependencies to latest ### Patch Changes - [#808](#808) [`8358da80`](8358da8) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Removing unnecessary conflicting CSS for #problemarea. - [#813](#813) [`691d29b4`](691d29b) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Removing unused CSS from #problemarea. - [#812](#812) [`6d31e044`](6d31e04) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Fix 'focus' parameter on Renderer's setInputValue function to be optional. - Updated dependencies \[[`57e0e18b`](57e0e18), [`57e0e18b`](57e0e18), [`bca527ab`](bca527a)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#811](#811) [`bca527ab`](bca527a) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Bump all Wonder Blocks dependencies to latest ### Patch Changes - [#808](#808) [`8358da80`](8358da8) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Removing unnecessary conflicting CSS for #problemarea. - Updated dependencies \[[`8358da80`](8358da8), [`691d29b4`](691d29b), [`021f9462`](021f946), [`bca527ab`](bca527a), [`6d31e044`](6d31e04)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#802](#802) [`57e0e18b`](57e0e18) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove unused dependencies: size-limit and uglify-js - [#802](#802) [`57e0e18b`](57e0e18) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove unused dependencies: size-limit and uglify-js ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`57e0e18b`](57e0e18), [`57e0e18b`](57e0e18)]: - @khanacademy/[email protected] ## [email protected] ### Minor Changes - [#802](#802) [`57e0e18b`](57e0e18) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Adjust builds so that less handles math the way it did in older versions. Author: khan-actions-bot Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage, ⏭ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress (ubuntu-latest, 16.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ gerald Pull Request URL: #803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates the color of rationales to match wonderblocks
Issue: https://khanacademy.atlassian.net/browse/LC-1137
Test plan: