-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WB-1814.8] Refactor Popover, Tooltip, Toolbar to use semantic colors #2470
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c0cb49c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +69 B (+0.07%) Total Size: 97.5 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-imkbxeudso.chromatic.com/ Chromatic results:
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (fe8f471) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2470" Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2470 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good! Left a comment in Chromatic on the diff to see what your thoughts were!
Summary:
Next step is to refactor the
Popover
,Tooltip
andToolbar
packages to usesemantic colors.
Implementation plan:
Issue: WB-1814
Test plan:
Verify that the Modal Chromatic snapshots are mostly unchanged.