Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cl_khr_defined_builtin_kernels #867

Closed

Conversation

pjaaskel
Copy link
Contributor

@pjaaskel pjaaskel commented Dec 13, 2022

First WiP draft of a defined BiKs extension.

See: KhronosGroup/OpenCL-Registry#131 for the background. HTML rendered here.

Any input appreciated!

First WiP draft of a defined BiKs extension.
@FreddieWitherden
Copy link

The documentation for khr_blas_gemm_float seems off. For GEMM we need three dimensions, but only two appear to be specified through NDRange. Also, the leading dimension arguments do not make sense as these are separate to row/column major (which should be its own argument). Also, the arguments should probably be size_t to allow for large multiplications.

@pjaaskel
Copy link
Contributor Author

Thanks for the feedback. The current GEMM BiK is supposed to be an example for the general concept of the extension, but it will definitely be one of the first ones to "freeze" in the registry. We'll take your input in account while shaping it.

@pjaaskel
Copy link
Contributor Author

Continuing the discussion in the updated PR.

@pjaaskel pjaaskel closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants