Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard provisional extensions with an opt-in define #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Nov 6, 2024

fixes #247

Wraps provisional extensions in an opt-in define so applications that do not use provisional extensions do not get broken by non-backwards compatible changes.

Notes:

  • The define gets added automatically during header generation based on the provisional="true" line in the XML file.
  • The define is currently an opt-in named CL_PROVISIONAL_EXTENSIONS, but it's trivial to change this if desired.
  • Because it is an opt-in define, the current implementation does break backwards compatiblity, and applications using provisional extensions will need to add the opt-in define.
  • We should consider how much additional testing we want to add (in this repo and in others) with this change. For example, do we want to run some of the header tests with and without provisional extensions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guard definitions for provisional extensions with a dedicated opt-in macro
1 participant