Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentAttributeINTEL decoration translation after nocapture attribute change #2983

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

vmaksimo
Copy link
Contributor

Update after llvm/llvm-project@29441e4f5fa5 ("[IR] Convert from nocapture to captures(none)")

svenvh and others added 3 commits January 30, 2025 10:48
Update after llvm-project commit 29441e4f5fa5 ("[IR] Convert from
nocapture to captures(none) (#123181)", 2025-01-29).

This includes a bulk replacement `s/nocapture/captures(none)/g` in the
test files.  A few of the `captures` attributes in CHECK lines had to
be reordered manually.
…ttribute change

Update after llvm/llvm-project@29441e4f5fa5 ("[IR] Convert from nocapture to captures(none)")
@vmaksimo
Copy link
Contributor Author

To be merged after or together with #2980

Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5c37745 LGTM

Copy link
Member

@svenvh svenvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those!

@svenvh
Copy link
Member

svenvh commented Feb 3, 2025

Close/reopen to restart CI.

@svenvh svenvh closed this Feb 3, 2025
@svenvh svenvh reopened this Feb 3, 2025
@MrSidims MrSidims merged commit 290f136 into KhronosGroup:main Feb 10, 2025
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants