Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VertexColor.cginc to fix Android build #542

Closed
wants to merge 1 commit into from

Conversation

marcspraragen
Copy link

Addresses issues #125, #540. Builds on solutions presented by Vytek (#213) and antoninklopp (#451)

@claassistantio
Copy link

claassistantio commented Jan 2, 2020

CLA assistant check
All committers have signed the CLA.

@marcspraragen
Copy link
Author

Note: at first build, variant compilation will throw "identifier not found" errors for the two shaders, but following builds work fine.

@mhochk
Copy link
Contributor

mhochk commented Jan 8, 2020

There's actually a bigger issue here that I'll get started on a fix for shortly. The root of the problem is the VertexColor.cginc code was made as a minimalistic wrapper of vertBase/fragBase, but doesn't include support for when UNITY_STANDARD_SIMPLE is set to true (which is apparently the case on Android builds).

This change currently let's you compile for Android, but shouldn't be working correctly for other targets (though I haven't tested to confirm this). Also even though it compiles for Android, it's not using the shader intended by Unity for Android, so there's probably some kind of fallout there.

@mhochk
Copy link
Contributor

mhochk commented Jan 9, 2020

Got a fix together and put out PR #547

@marcspraragen
Copy link
Author

Oh wow thanks! I had noticed this too but didn't have time to set up a fix. I noticed it's up in master branch already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants