Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gltf Asset informations to Importer Inspector #774

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

pfcDorn
Copy link
Contributor

@pfcDorn pfcDorn commented Sep 4, 2024

Enhanced the importer inspector to show the gltf asset informations:

image
image

The informations will be stored in the importer as a multiline string from the new ToString methods in the gltf "Asset" class.

@hybridherbst
Copy link
Collaborator

cc @marwie

@marwie
Copy link
Contributor

marwie commented Sep 4, 2024

Which glTF files did you use here? Do you omit the extras info in the first screenshot when there's Copyright information in the glTF?

How would it look with this glb? https://cloud.needle.tools/api/v1/public/9283996/105938669/mustang_sunglasses_-_mu_1683.glb

@pfcDorn pfcDorn force-pushed the enhancement/show-asset-infos-in-importer branch from 0fa9830 to 34c5bad Compare September 4, 2024 16:58
@pfcDorn
Copy link
Contributor Author

pfcDorn commented Sep 4, 2024

Was two different files. One without containing the extras.

Here's your file:

image

… extend the Importer Inspector with new Info tab
@pfcDorn pfcDorn force-pushed the enhancement/show-asset-infos-in-importer branch from 34c5bad to 0665439 Compare September 12, 2024 09:49
@hybridherbst hybridherbst merged commit abef38c into dev Sep 20, 2024
1 check passed
@hybridherbst hybridherbst deleted the enhancement/show-asset-infos-in-importer branch October 6, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants