-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues encountered in the loader. #1437
Conversation
If we never find any other device after already_enumerated is recognized, the memory allocated in this function will never be freed.
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
@charles-lunarg please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that certainly is a memory leak!
Thank you for going ahead and fixing the issue, loader changes look good as well as the test framework.
@zaiste-linganer Unfortunately I will require that the code formatting be fixed before I can merge it. |
Yes, I'm aware and will update formatting today :) |
3f28179
to
339115f
Compare
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
Updated formatting that was mentioned in the failure output. |
No, I didn't. Sorry, will reupload again. |
LUID is expected to be unique per D3DKMT_/DXGIAdapter.
339115f
to
edcb720
Compare
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
No description provided.