Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues encountered in the loader. #1437

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

zaiste-linganer
Copy link
Contributor

No description provided.

If we never find any other device after already_enumerated is recognized, the memory allocated in this function will never be freed.
@ci-tester-lunarg
Copy link

Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build.

@zaiste-linganer
Copy link
Contributor Author

@charles-lunarg please have a look.

Copy link
Collaborator

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that certainly is a memory leak!
Thank you for going ahead and fixing the issue, loader changes look good as well as the test framework.

@charles-lunarg
Copy link
Collaborator

@zaiste-linganer Unfortunately I will require that the code formatting be fixed before I can merge it.

@zaiste-linganer
Copy link
Contributor Author

@zaiste-linganer Unfortunately I will require that the code formatting be fixed before I can merge it.

Yes, I'm aware and will update formatting today :)

@ci-tester-lunarg
Copy link

Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build.

@zaiste-linganer
Copy link
Contributor Author

Updated formatting that was mentioned in the failure output.

@zaiste-linganer
Copy link
Contributor Author

Updated formatting that was mentioned in the failure output.

No, I didn't. Sorry, will reupload again.

@ci-tester-lunarg
Copy link

Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build.

@charles-lunarg charles-lunarg merged commit af26525 into KhronosGroup:main Feb 1, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants