fix dEQP-VK.api.object_management.multithreaded_per_thread_resources.…

[RobinMorrisLuo]

…device_group crash

This commit reverts the a4ff6a5, which will cause this CTS case crash when build the loader with release type.

[CLAassistant]

All committers have signed the CLA.

[ci-tester-lunarg]

Author MrRobbin not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author MrRobbin not on autobuild list. Waiting for curator authorization before starting CI build.

[RobinMorrisLuo]

Hi @charles-lunarg Regarding this issue #1436

I found that if we build loader with -DCMAKE_BUILD_TYPE=Release, then will reproduce this issue. The default build option will not. And I also found this regression.
Please take a look. Thanks

[charles-lunarg]

I did wonder if removing this option would secretly cause crashes.

And maybe there is a 'fix' for the device group code, but I'd rather not leave that possibility on the table.

Thank you for going ahead and debugging & finding the cause of the issue! Aliasing certainly would be harder to reproduce since it requires on the compiler making assumptions about the build.