Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Default to VULKANSC=ON #25

Merged
merged 1 commit into from
Apr 8, 2024
Merged

build: Default to VULKANSC=ON #25

merged 1 commit into from
Apr 8, 2024

Conversation

aqnuep
Copy link
Contributor

@aqnuep aqnuep commented Apr 3, 2024

No description provided.

@aqnuep aqnuep requested a review from dgkoch April 3, 2024 14:15
@aqnuep aqnuep force-pushed the vulkansc-on branch 2 times, most recently from 53e9fc6 to a70d577 Compare April 3, 2024 16:46
dgkoch
dgkoch approved these changes Apr 3, 2024
View reviewed changes
Copy link

@dgkoch dgkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem ok. I presume you'll address the CI issues before merging.

@aqnuep
Copy link
Contributor Author

aqnuep commented Apr 5, 2024

Code changes seem ok. I presume you'll address the CI issues before merging.

Of course. I'm on it.

@aqnuep aqnuep force-pushed the vulkansc-on branch 6 times, most recently from 27a112a to 8b521ed Compare April 8, 2024 12:46
@aqnuep aqnuep merged commit d5f846a into sc_main Apr 8, 2024
23 checks passed
@aqnuep aqnuep deleted the vulkansc-on branch October 4, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgkoch dgkoch dgkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aqnuep @dgkoch