Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
elalish committed May 2, 2024
1 parent a86a5d9 commit 5c34356
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
1 change: 1 addition & 0 deletions scripts/ci-before-deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ DEPLOY_ROOT=$PACKAGE_ROOT/pages
set -x

# Copy the latest fidelity testing results:
mkdir $DEPLOY_ROOT/results
mv test/results $DEPLOY_ROOT/results/
cp test/results-viewer.html $DEPLOY_ROOT/index.html
cp -r dist $DEPLOY_ROOT/
Expand Down
12 changes: 1 addition & 11 deletions test/results-viewer.html
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,6 @@
</head>

<body>
<div class="home lockup">
<a href="../" class="sidebar-mv inner-home">
<div class="icon-button icon-modelviewer-black inner-home"></div>
<div class="inner-home"><span class="attribute">&lt;model-viewer&gt;</span></div>
</a>
</div>
<div align="center">
<h2>Render Fidelity Comparison Results</h2>
<p>The purpose of <a href="https://www.khronos.org/gltf/" target="_blank" rel="noopener">glTF</a> is to standardize
Expand Down Expand Up @@ -150,7 +144,7 @@ <h2>Render Fidelity Comparison Results</h2>
</table>
<p>If any other renderers would like to be included, please open a PR adding them to the <a
href="https://github.com/KhronosGroup/glTF-Render-Fidelity" target="_blank"
rel="noopener">render-fidelity-tools</a> package.</p>
rel="noopener">glTF-Render-Fidelity</a> repository.</p>
<p>The first set of scenarios are for demonstrating material capabilities, so these are primarily fidelity tests.
Following these are simpler cases that test glTF spec conformance, but are not particularly interesting for
fidelity. At the bottom are the Furnace Test and the Directional Light Test. The Furnace Test checks energy
Expand All @@ -159,10 +153,6 @@ <h2>Render Fidelity Comparison Results</h2>
mixtures lose some energy. The Directional Light Test checks the worst-case scenario for environmental lighting
approximations: the case where a single bright pixel represents a directional light. The Filament version uses an
actual directional light, so this is the ground truth.</p>
<p>In &lt;model-viewer&gt;, we do not consider rendering changes to be breaking changes, as our quality is
incrementally improving with every release. However, the difference between the renders you see here bounds how
much you can expect our rendering to change going forward. Note the largest differences are in the handling of
transparent materials, as this is quite difficult to get right, so the largest changes will likely be here.</p>
<p>We show a simple logarithmic metric on an average of the pixel differences, excluding the transparent background.
This is <b>not</b> a perceptual metric, so take it with a grain of salt. It is mostly there to help us identify
regressions.</p>
Expand Down

0 comments on commit 5c34356

Please sign in to comment.