Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit debug info for accelerationStructure and rayQuery variables. #3502

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

sajjadmirzanv
Copy link
Contributor

@sajjadmirzanv sajjadmirzanv commented Feb 10, 2024

A minor quirk is that multiple source types will get mapped to the same debug type, for example both accelerationStructureNV and accelerationStructureEXT are just named accelerationStructure. But I expect a shader author won't use both extensions in the same program, they'll just pick one, so this should be OK.

@arcady-lunarg
Copy link
Contributor

In the underlying SPIR-V OpTypeAccelerationStructureNV and OpTypeAccelerationStructureKHR have the same opcode, so it's kind of hard to avoid conflating them into just one type.

@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Feb 12, 2024
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Feb 12, 2024
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this? The change itself looks fine and isn't doing a lot, just adding an empty struct for the acceleration structure so the test should be fairly trivial to write.

@sajjadmirzanv
Copy link
Contributor Author

Added a test case (copy of an existing one, rayQuery.rgen)

Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Feb 15, 2024
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Feb 15, 2024
@arcady-lunarg arcady-lunarg merged commit 7a2a162 into KhronosGroup:main Feb 15, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants