Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GL_NV_cluster_acceleration_structure. #3860

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

alelenv
Copy link
Contributor

@alelenv alelenv commented Feb 3, 2025

GLSL spec : KhronosGroup/GLSL#274
SPV spec : KhronosGroup/SPIRV-Registry#311

Headers and tools already merged

@alelenv
Copy link
Contributor Author

alelenv commented Feb 4, 2025

@arcady-lunarg or @jeremy-lunarg can you review?
Thanks

@jeremy-lunarg
Copy link
Contributor

@arcady-lunarg or @jeremy-lunarg can you review? Thanks

I'll take a look. Thanks for the rebase.

Copy link
Contributor

@jeremy-lunarg jeremy-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremy-lunarg
Copy link
Contributor

@alelenv Can you take a look at the conflicts?

@alelenv
Copy link
Contributor Author

alelenv commented Feb 4, 2025

@jeremy-lunarg : I don't see any conflicts and tests are also clean
Am I missing something?

@jeremy-lunarg
Copy link
Contributor

Your branch has Jeff's cooperative vector changes, which already landed on main, on top of the changes for this extension.

@alelenv
Copy link
Contributor Author

alelenv commented Feb 4, 2025

@jeremy-lunarg : My bad, should be looking okay now

@jeremy-lunarg
Copy link
Contributor

Thanks @alelenv

@jeremy-lunarg jeremy-lunarg merged commit 39766a0 into KhronosGroup:main Feb 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants