-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove thiserror in favor of derive_more #50
Conversation
… for the error enums, dropping the error trait that was messing with the no_std builds
LGTM. Is this ready to land? |
You might want to change CI to test against stable rather than nightly: zstd-rs/.github/workflows/ci.yml Lines 78 to 140 in e15eb1e
|
Dang, They bumped the dependency in JelteF/derive_more@1fb07f1 but it is not yet released. |
Yep but they are having beta releases for a 1.0 which makes ma hopeful that this will soon be rectified I'm pretty busy right now, I'll try and merge this next week |
Okay so I think the way I'm going to handle this is merging this, and bumping derive_more to 1.0 once they release it. This will allow all three goals above to be reached now and gives a clear-ish roadmap (wait for derive_more 1.0 release) towards not compiling syn 1.0 AND syn 2.0 in the future. |
Cool, thanks. Will you cut a new release with this change? |
Today @tamird ;) |
This switches to derive_more so we get
Fixes: #47