Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Log File Output #28

Closed
kozzy97 opened this issue Dec 4, 2023 · 8 comments · Fixed by #39
Closed

Clean Up Log File Output #28

kozzy97 opened this issue Dec 4, 2023 · 8 comments · Fixed by #39
Assignees
Labels
enhancement New feature or request

Comments

@kozzy97
Copy link
Member

kozzy97 commented Dec 4, 2023

The log file that is outputted is very messy, and doesn't contain all information. It should preferably return two things:

  1. Log file with system information
  2. CSV/JSON(L) with step by step observation information (positions, velocities, reward), that can be used as the basis for returning more information about the environment in future versions.
@alhasacademy96
Copy link
Member

@kozzy97 wasn't this closed with PR #30 ?

@kozzy97
Copy link
Member Author

kozzy97 commented Feb 5, 2024

sorry for the slow reply @alhasacademy96 . No, the log file is still pretty messy and difficult to use, but it now records the data we need from players. We should talk about how to clean up the outputs so its more usable!

@alhasacademy96
Copy link
Member

Hi @kozzy97, what is the expected output log file format? I think if i got an idea i could get this done quickly.

@kozzy97
Copy link
Member Author

kozzy97 commented Mar 13, 2024

Hey @alhasacademy96 !

Currently the log file outputs several system details, which is good for debugging. Then, it outputs some details about the start of the episode and then for each time step it outputs the agent's health, velocity, position, forward, orient, and current score.

I am proposing that this latter information gets output into a CSV file rather than in the log as the following:

Arena Name Step Health xvelocity yvelocity zvelocity xpos ypos zpos
ArenaName1 0 100 0 0 0 20 0.5 0
ArenaName1 1 99.9 0 0 0 20 0.5 0
... ... ... ... ... ... ... ... ...

This is useful because currently the only way to get this information is by parsing the log file, which is quite a burden if you're new to using AAI. If we provide it as a CSV (or JSON(L) or TSV or something like that), then it'll be much easier to use than a log file.

All system information that might be important to debug should still go in the log file, though.

@alhasacademy96
Copy link
Member

In development now. See notion doc file for details.

@alhasacademy96
Copy link
Member

BRANCH REF: feature-cleanup-observations

Copy link

This issue is stale because it has been open for 45 days with no activity.

@github-actions github-actions bot added the stale label Jun 27, 2024
@alhasacademy96 alhasacademy96 linked a pull request Aug 16, 2024 that will close this issue
12 tasks
Copy link

This issue was closed because it has been inactive for 50 days since being marked as stale. Please open a new issue for related bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants