A plethora of improvements and additions #39
Conversation
its foundational right now and saves per step information on agent. it needs to be able to save the .csv file outside of the root directory (currently in unity folder so not ideal to user). Next step would be to save to desktop or better still to save the .csv in a specified location in the yaml file as a new syntax.
However, it needs to be cleaned up further.
The logs are now stored in a folder called observationLogs, in editor, play and train modes. The location of the editor/play is root directory, where in the build/training, it's currently: ""C:\Users\ia424\Desktop\WINDOWS\AnimalAI_Data\observationLogs\Observations.csv"" (on my PC). Next would need to see if we can store the folder and .csv files one directory up or potentially in root directory. Will also need to see if there is any FPS lag as the data is being written simultaneously for obvious reasons...
for editor, in root directory of project files and; for builds, in root directory of .exe file. Ideally, the logic for this feature should have its own class (and will so in the future). Tested on editor plus builds running on play and train modes. The folder and files are produced as expected.
works on manual + editor. Couldn't test on training as mlagents error occurred today (attributeerror). Changes: added code to log action vector and appended to attributes list (headers in .csv file). Made actionForward and actionRotate global variables. Properly handled onDisable() so it disables streamIO writer correctly. Removed dublicate logic/code for logging data to .csv
also hidden the yaml data UI - this will be used for testing purposes only.
unfreezeCountdown ---> UnfreezeCountdown
tested and confimed
action movement and rotation
alhasacademy96
requested review from
benaslater
and removed request for
benaslater
The objects now have increased masses to reflect their purposes. J/L/U Blocks: 180 Light/Heavy Blocks: 220/440
The original colliders set to these objects were partially setup. They are now complete. Fixes the issues where the agent would go through the object's part where no collider was set (i.e., corners of the UBlock).
for less clutter
There was a problem hiding this comment.
I've added some superficial comments up to around Assets/Scripts/DataZone.cs. The issue is I don't think I can follow all the changes and how they fit together, so I can't confidently review this - is there any possibility you could split this out into some more self-contained PRs? e.g. you could do one for each point under general, perhaps with the last two merged, and make additional ones for anything that doesn't fit under the heading of any of these points
|
I've resolved the comments but if they're still valid, reopen them @benaslater. |
That could make things worse in my experience. I think the PR is self explanatory but also admittedly a bit disorganised. I've highlighted the important changes in the PR description and the commits themselves are informative largely. The most important changes occur in the scripts. I understand your legitimate concerns but the PR is still valid and sound. You can take your time no rush :) Also let me know what exactly confuses you. I will be able to explain more clearly. |
Proposed change(s)
General:
.gititnorefile (so the.csvfiles generated are not tracked during development).Moq/NSubstitutefor enhanced Mocking testing in later stages.ArenasParameter.cs (ArenasConfiguration).Bug Fixes:
RipenGoal.Project Changes:
ProgressBar.csscript to Scripts folder for organisation.YAML Syntax Changes:
tandpass_Markto betimeLimitandpassMark, respectively. In effect from AAI versions 4.1.0 and above.UI Changes:
Build Version. A small text element in the bottom-right corner to display the current version of AAI (build) to the user.Useful links (Github issues, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments
Screenshots (if any)