Record refresh bugfix and simple-review enhancement to hide rollback button #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed correctly whenever the collection is modified
leplatrem
approved these changes
Nov 9, 2023
src/locationUtils.ts
Outdated
| return [["home", "/"]].concat(zip(crumbNames, crumbPaths)); | ||
| } | ||
|
|
||
| // This may become obsolete when upgrading or switching router packages |
There was a problem hiding this comment.
nitpick: can we add notes about current/expected versions or upgrade PR number
src/sagas/collection.ts
Outdated
| @@ -53,7 +53,7 @@ export function* listRecords( | |||
| limit: MAX_PER_PAGE, | |||
| }); | |||
| // Show list of records. | |||
| yield put(actions.listRecordsSuccess(data, hasNextPage, next)); | |||
| yield put(actions.listRecordsSuccess(data, hasNextPage, next, false)); | |||
There was a problem hiding this comment.
nitpick: can we add a little annotation for this false? like:
Suggested change
| yield put(actions.listRecordsSuccess(data, hasNextPage, next, false)); | |
| yield put(actions.listRecordsSuccess(data, hasNextPage, next, /* isNextPage: */ false)); |
src/sagas/collection.ts
Outdated
| @@ -71,7 +71,7 @@ export function* listNextRecords(getState: GetStateFn): SagaGen { | |||
| } | |||
| try { | |||
| const { data, hasNextPage, next } = yield call(listNextRecords); | |||
| yield put(actions.listRecordsSuccess(data, hasNextPage, next)); | |||
| yield put(actions.listRecordsSuccess(data, hasNextPage, next, true)); | |||
| return { | ||
| ...state, | ||
| records: [...state.records, ...records], | ||
| records: isNextPage ? [...state.records, ...records] : records, |
There was a problem hiding this comment.
I'm not sure that I understand this. Maybe isNextPage does not represent what we are really doing here?
Could you please add a comment why we skip state.records when isNextPage?
| @@ -57,18 +57,21 @@ export function listNextRecords(): { | |||
| export function listRecordsSuccess( | |||
| records: RecordData[], | |||
| hasNextRecords: boolean, | |||
| listNextRecords: Function | null | undefined | |||
| listNextRecords: Function | null | undefined, | |||
| isNextPage: boolean = false | |||
There was a problem hiding this comment.
What alternative names would we have for this isNextPage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves two issues and adds unit tests around them:
Note: The added the query param is only useful while the user does not navigate away and back. Should this be a change that needs to be persisted throughout the session please leave a comment and I'll adjust the code to save this to sessionStorage and check against that.
Video demos showing fixes:
simplescreenrecorder-2023-11-07_10.25.29.mp4
simplescreenrecorder-2023-11-08_10.13.16.mp4