Fixes 616 - Adds file attachment logic to JSONRecordForm and tests #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
approved these changes
Nov 14, 2023
src/components/record/RecordForm.tsx
Outdated
| @@ -170,6 +170,9 @@ export default function RecordForm(props: Props) { | |||
| disabled={!allowEditing} | |||
| record={JSON.stringify(recordData, null, 2)} | |||
| onSubmit={handleOnSubmit} | |||
| attachmentEnabled={attachment?.enabled} | |||
| // require an attachment on initial insert if attachments are required | |||
There was a problem hiding this comment.
This comment could mention the fact that we don't want to require attachments on existing records, because we want to be able to edit the fields without having to reupload its attachment? Or is it obvious?
| const attachment = jsRecord.attachment || {}; | ||
| if (jsRecord.attachment) { | ||
| delete jsRecord.attachment; | ||
| } |
There was a problem hiding this comment.
nitpick: We have omit() in utils for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 616 by adding a file attachment input to the JSONRecordForm component.