Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename build directory from dist to build #3122

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

grahamalama
Copy link
Contributor

Goes from a vite default to our old directory name, with the intention of being more backwards-compatible

Goes from a vite default to our old directory name, with the intention of being more backwards-compatible
@leplatrem
Copy link
Contributor

leplatrem commented Jan 17, 2024

Upgrading from v2.1.1 to v2.1.2 (mainly with #3104) indeed broke a number of things in mozilla/remote-settings#527

The list of built assets is also different, and our admin plugin expects a index.html file. Update: error was on my side, moved the assets/ folders whereas the index.html is in the dist/ folder

With 2.1.1:

$ ls -lh kinto-admin/build/
total 6688
-rw-r--r--  1 mathieu  staff   4.8K Jan 17 11:53 121.bundle.js
-rw-r--r--  1 mathieu  staff    26K Jan 17 11:53 136.bundle.js
-rw-r--r--  1 mathieu  staff   1.7K Jan 17 11:53 171.bundle.js
-rw-r--r--  1 mathieu  staff   4.0K Jan 17 11:53 203.bundle.js
-rw-r--r--  1 mathieu  staff    16K Jan 17 11:53 296.bundle.js
-rw-r--r--  1 mathieu  staff   6.5K Jan 17 11:53 323.bundle.js
-rw-r--r--  1 mathieu  staff    11K Jan 17 11:53 406.bundle.js
-rw-r--r--  1 mathieu  staff   1.5K Jan 17 11:53 40d5dfabf4efa0a31d3b.svg
-rw-r--r--  1 mathieu  staff   1.3K Jan 17 11:53 5b83b710e5b7b55c9acc.svg
-rw-r--r--  1 mathieu  staff    36K Jan 17 11:53 607.bundle.js
-rw-r--r--  1 mathieu  staff   1.7K Jan 17 11:53 807062d10085674b964b.svg
-rw-r--r--  1 mathieu  staff   4.1K Jan 17 11:53 831.bundle.js
-rw-r--r--  1 mathieu  staff   1.7K Jan 17 11:53 bf3372c179a5e966b4a8.svg
-rw-r--r--  1 mathieu  staff   2.9M Jan 17 11:53 bundle.js
-rw-r--r--  1 mathieu  staff   3.0K Jan 17 11:53 bundle.js.LICENSE.txt
-rw-r--r--  1 mathieu  staff   5.4K Jan 17 11:53 f30734eaadbe6c483578.png
-rw-r--r--  1 mathieu  staff    10K Jan 17 11:53 favicon.png
-rw-r--r--  1 mathieu  staff   405B Jan 17 11:53 index.html
-rw-r--r--  1 mathieu  staff   209K Jan 17 11:53 styles.css

With 2.1.2:

$ ls -lh kinto-admin/build-21.1.2
total 6288
-rw-r--r--  1 mathieu  staff   3.9K Jan 17 11:45 asn1-8gHclKtu.js
-rw-r--r--  1 mathieu  staff    11K Jan 17 11:45 clojure-plf_rynZ.js
-rw-r--r--  1 mathieu  staff    26K Jan 17 11:45 css-tpsEXL3H.js
-rw-r--r--  1 mathieu  staff   167K Jan 17 11:45 index-0tPkNRbd.css
-rw-r--r--  1 mathieu  staff   2.8M Jan 17 11:45 index-TaUmH-SN.js
-rw-r--r--  1 mathieu  staff    17K Jan 17 11:45 javascript-upQ8KtFH.js
-rw-r--r--  1 mathieu  staff   5.4K Jan 17 11:45 logo-FQUYikj1.png
-rw-r--r--  1 mathieu  staff   4.7K Jan 17 11:45 mllike-ilm95jrV.js
-rw-r--r--  1 mathieu  staff   6.3K Jan 17 11:45 python-xljIYvii.js
-rw-r--r--  1 mathieu  staff   1.6K Jan 17 11:45 rpm-cddeyEgF.js
-rw-r--r--  1 mathieu  staff    36K Jan 17 11:45 sql-3IaSLchm.js
-rw-r--r--  1 mathieu  staff   4.0K Jan 17 11:45 ttcn-cfg-9oMIyPXS.js

~~

@grahamalama
Copy link
Contributor Author

Hmm, there should definitely be an index.html in the bundle

> npm run build
...
> ls -l build
total 8
drwxr-xr-x  14 gbeckley  staff  448 Jan 16 15:30 assets
-rw-r--r--   1 gbeckley  staff  449 Jan 16 15:30 index.html

@grahamalama grahamalama merged commit 692cee2 into master Jan 17, 2024
6 checks passed
@grahamalama grahamalama deleted the different-build-dir branch January 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants