Standardizing spinner placement and adding missing spinners, Fixes #689 #3226
Conversation
alexcottner
changed the title
| deleteBucket={handleDeleteBucket} | ||
| onSubmit={handleSubmit} | ||
| /> | ||
| {busy ? ( |
There was a problem hiding this comment.
Prettier, why do you like unnecessary parenthesis?
| @@ -196,6 +194,8 @@ export default function SimpleReview({ | |||
| ); | |||
| }; | |||
|
|
|||
| console.warn(records); | |||
| formData={formData} | ||
| onSubmit={onSubmit} | ||
| /> | ||
| {busy || formData == null ? ( |
There was a problem hiding this comment.
Can you add a comment here to explain why we have this condition on formData ?
There was a problem hiding this comment.
Added a comment, but it's just redux lifecycle quirkiness
| } else if ( | ||
| session.authenticating || | ||
| session.busy || | ||
| (records.loading && signoffSource && signoffDest) |
There was a problem hiding this comment.
I don't recall why we had this condition
There was a problem hiding this comment.
I think we were just having one spinner for any of the conditions. In this case if we're waiting for auth, waiting for session info to load, waiting for the records to load, or waiting for the signoff info to load just show a spinner.
But now we've broken it up. If we have enough context to render the tabs (auth and session) we do so. And then we show a spinner under the tabs if we're waiting for the records or signoff info still.
Goal of this PR is to add missing spinners and standardize spinner placement.
BucketTabs), spinner should exist inside of the tab control if we have enough contextCollectionDataList), spinner should exist inside the table if we have enough context