Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the Volcano execution engine to avoid using RefCell #123

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Jan 30, 2024

What problem does this PR solve?

RefCell removes the transaction encapsulation, reduces runtime overhead and improves code readability, and turns the input of the operator into a plan, making Explain easier to implement.

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould requested a review from guojidan January 30, 2024 17:19
@KKould KKould self-assigned this Jan 30, 2024
@KKould KKould added the enhancement New feature or request label Jan 30, 2024
@KKould KKould merged commit ad7cbb5 into KipData:main Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant